From: Daniel Colascione <dancol@dancol.org>
To: Nicolas Petton <petton.nicolas@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] sequence manipulation functions
Date: Fri, 07 Nov 2014 17:43:07 +0000 [thread overview]
Message-ID: <545D04AB.6090201@dancol.org> (raw)
In-Reply-To: <87zjc2dic0.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
On 11/07/2014 05:35 PM, Nicolas Petton wrote:
> Hi,
>
> Here is a patch containing the new version of sequences.el and its
> associated test file
Why do you want to dump these functions with Emacs?
> +(defun seq-sort (seq pred)
> + "Return a sorted list of the elements of SEQ compared using PRED."
> + (if (listp seq)
> + (sort (seq-copy seq) pred)
> + (seq-sort (append seq nil) pred)))
If you insist on adding seq- prefixed functions (and I don't think you
should, contra rms), you should make an alias, not a wrapper. You're
aware that we have native sort support for vectors and don't to coerce
to a list first, right?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-07 17:43 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 22:17 sequence manipulation functions Nicolas Petton
2014-11-05 1:21 ` Glenn Morris
2014-11-05 9:46 ` Nicolas Petton
2014-11-05 4:58 ` Richard Stallman
2014-11-05 9:45 ` Nicolas Petton
2014-11-06 0:54 ` Daniel Colascione
2014-11-05 9:23 ` Damien Cassou
2014-11-05 18:12 ` Richard Stallman
2014-11-05 21:59 ` Nicolas Petton
2014-11-05 22:40 ` Stefan Monnier
2014-11-06 0:30 ` Richard Stallman
2014-11-05 15:26 ` Stefan Monnier
2014-11-05 15:36 ` Nicolas Petton
2014-11-05 15:52 ` Sebastien Vauban
2014-11-05 18:32 ` Stefan Monnier
2014-11-07 17:35 ` [PATCH] " Nicolas Petton
2014-11-07 17:43 ` Daniel Colascione [this message]
2014-11-10 17:41 ` Stefan Monnier
2014-11-10 22:28 ` Nicolas Petton
2014-11-10 23:12 ` Nicolas Petton
2014-11-11 2:20 ` Stefan Monnier
2014-11-12 17:49 ` Nicolas Petton
2014-11-12 19:12 ` Bozhidar Batsov
2014-11-12 19:30 ` Nicolas Petton
2014-11-12 20:28 ` Stefan Monnier
2014-11-12 20:56 ` Nicolas Petton
2014-11-12 23:06 ` Nicolas Petton
2014-11-12 23:17 ` Nic Ferrier
2014-11-13 1:29 ` Leo Liu
2014-11-13 5:21 ` Drew Adams
2014-11-14 5:16 ` Leo Liu
2014-11-16 12:52 ` Bozhidar Batsov
2014-11-16 14:16 ` Nicolas Petton
2014-11-16 17:22 ` Drew Adams
2014-11-16 19:13 ` Stefan Monnier
2014-11-17 2:52 ` Richard Stallman
2014-11-17 11:46 ` Nicolas Petton
2014-11-17 13:53 ` Stefan Monnier
2014-11-16 7:38 ` Damien Cassou
2014-11-20 23:16 ` Stefan Monnier
2014-11-21 12:40 ` Nicolas Petton
2014-11-21 13:11 ` Stefan Monnier
2014-11-21 13:28 ` Nicolas Petton
2014-11-21 14:44 ` Stefan Monnier
2014-11-24 17:49 ` Nicolas Petton
2014-11-24 18:01 ` Nicolas Petton
2014-11-05 16:25 ` Drew Adams
2014-11-05 17:21 ` Artur Malabarba
2014-11-05 18:27 ` Drew Adams
2014-11-05 17:22 ` Damien Cassou
2014-11-05 18:28 ` Drew Adams
2014-11-05 17:41 ` Nicolas Petton
2014-11-05 18:23 ` Tom Tromey
2014-11-05 18:29 ` Drew Adams
2014-11-05 18:29 ` Drew Adams
2014-11-06 4:39 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545D04AB.6090201@dancol.org \
--to=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=petton.nicolas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).