From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Possibility of a ${srcdir}/info/dir target race? Date: Wed, 22 Oct 2014 23:36:08 -0700 Organization: UCLA Computer Science Department Message-ID: <5448A1D8.10605@cs.ucla.edu> References: <877fzrkje1.fsf@trouble.defaultvalue.org> <87r3xzirqs.fsf@trouble.defaultvalue.org> <544878F7.6020708@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1414046213 10642 80.91.229.3 (23 Oct 2014 06:36:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Oct 2014 06:36:53 +0000 (UTC) Cc: Rob Browning , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 23 08:36:46 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XhC0s-0005oU-IO for ged-emacs-devel@m.gmane.org; Thu, 23 Oct 2014 08:36:46 +0200 Original-Received: from localhost ([::1]:35227 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhC0s-0003JI-6N for ged-emacs-devel@m.gmane.org; Thu, 23 Oct 2014 02:36:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhC0T-0003BJ-9z for emacs-devel@gnu.org; Thu, 23 Oct 2014 02:36:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XhC0N-0000LQ-8F for emacs-devel@gnu.org; Thu, 23 Oct 2014 02:36:21 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:51730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhC0N-0000LJ-2D; Thu, 23 Oct 2014 02:36:15 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 69921A60056; Wed, 22 Oct 2014 23:36:13 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hS5xY6TEHJeY; Wed, 22 Oct 2014 23:36:08 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-71-177-17-123.lsanca.dsl-w.verizon.net [71.177.17.123]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 4CDD8A60048; Wed, 22 Oct 2014 23:36:08 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:175716 Archived-At: Glenn Morris wrote: > Surely the actual relevant change is only to add ${MKDIR_P} > ${srcdir}/info, which could easily have been applied to emacs-24, only > it's mixed in with unrelated performance improvements? I didn't bother, because I didn't think any part of the change should be applied to emacs-24. As you mentioned, an 'info' dir shouldn't go missing with any normal use of an Emacs distribution tarball. The Debian build process is quite specialized and surely the Debian folks can get it to work themselves, e.g., by doing a "mkdir info" after the "make bootstrap-clean" (or better yet, omit the bootstrap-clean). > Similar constructs have been used for years in eg lisp/Makefile.in > lisptagsfiles etc. Ah, sorry, I was wrong about the wildcards. I didn't know that GNU make expanded wildcards in prerequisites. So that part of the change didn't fix any bugs (though the use of the 'wildcard' function is still helpful). I have fixed the corresponding ChangeLog entry accordingly, in trunk bzr 118182. That bzr also removes a couple of other calls to 'wildcard' that were present only because of the same misunderstanding of how wildcards work in prerequisites.