unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: Rob Browning <rlb@defaultvalue.org>, emacs-devel@gnu.org
Subject: Re: Possibility of a ${srcdir}/info/dir target race?
Date: Wed, 22 Oct 2014 23:36:08 -0700	[thread overview]
Message-ID: <5448A1D8.10605@cs.ucla.edu> (raw)
In-Reply-To: <mka94n4a80.fsf@fencepost.gnu.org>

Glenn Morris wrote:
> Surely the actual relevant change is only to add ${MKDIR_P}
> ${srcdir}/info, which could easily have been applied to emacs-24, only
> it's mixed in with unrelated performance improvements?

I didn't bother, because I didn't think any part of the change should be applied 
to emacs-24.  As you mentioned, an 'info' dir shouldn't go missing with any 
normal use of an Emacs distribution tarball.  The Debian build process is quite 
specialized and surely the Debian folks can get it to work themselves, e.g., by 
doing a "mkdir info" after the "make bootstrap-clean" (or better yet, omit the 
bootstrap-clean).

> Similar constructs have been used for years in eg lisp/Makefile.in
> lisptagsfiles etc.

Ah, sorry, I was wrong about the wildcards.  I didn't know that GNU make 
expanded wildcards in prerequisites.  So that part of the change didn't fix any 
bugs (though the use of the 'wildcard' function is still helpful).  I have fixed 
the corresponding ChangeLog entry accordingly, in trunk bzr 118182.  That bzr 
also removes a couple of other calls to 'wildcard' that were present only 
because of the same misunderstanding of how wildcards work in prerequisites.



  reply	other threads:[~2014-10-23  6:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 19:13 Possibility of a ${srcdir}/info/dir target race? Rob Browning
2014-10-22 20:11 ` Stefan Monnier
2014-10-22 21:22   ` Glenn Morris
2014-10-22 23:18     ` Rob Browning
2014-10-22 23:55   ` Rob Browning
2014-10-23  3:41     ` Paul Eggert
2014-10-23  5:32       ` Glenn Morris
2014-10-23  5:49         ` Glenn Morris
2014-10-23 15:20           ` Rob Browning
2014-10-23  5:38       ` Glenn Morris
2014-10-23  6:36         ` Paul Eggert [this message]
2014-10-23 15:22         ` Rob Browning
2014-10-23 15:43       ` Rob Browning

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5448A1D8.10605@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    --cc=rlb@defaultvalue.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).