* Pre-load time-date.el
@ 2014-10-16 16:47 Eli Zaretskii
2014-10-16 18:03 ` Glenn Morris
0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2014-10-16 16:47 UTC (permalink / raw)
To: emacs-devel
Since we turn on blink-cursor mode by default, and it requires timers,
we now always load time-date.el at startup. Any reasons not to
pre-load it in loadup.el on the emacs-24 branch?
(Please respond before the moratorium on commits at 00:00 UTC
tomorrow.)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Pre-load time-date.el
2014-10-16 16:47 Pre-load time-date.el Eli Zaretskii
@ 2014-10-16 18:03 ` Glenn Morris
2014-10-16 18:22 ` Glenn Morris
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Glenn Morris @ 2014-10-16 18:03 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii wrote:
> Since we turn on blink-cursor mode by default, and it requires timers,
> we now always load time-date.el at startup. Any reasons not to
> pre-load it in loadup.el on the emacs-24 branch?
This is not a new issue, right? It goes back to 24.1?
And it causes no measurable harm?
So why the rush to change it at the last minute?
(My fear would be that it somehow causes purespace overflow on some
platform. Maybe that is totally unfounded?)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Pre-load time-date.el
2014-10-16 18:03 ` Glenn Morris
@ 2014-10-16 18:22 ` Glenn Morris
2014-10-16 18:42 ` Eli Zaretskii
2014-10-16 18:24 ` Eli Zaretskii
2014-10-16 20:08 ` Stefan Monnier
2 siblings, 1 reply; 12+ messages in thread
From: Glenn Morris @ 2014-10-16 18:22 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
PS since the cursor blinks in 23.4, why does it not happen there?
Maybe timer--time-less-p "now" just using time-less-p is the cause?
(Uninvestigated.) So maybe it can actually be avoided, though obviously
that's definitely something for trunk.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Pre-load time-date.el
2014-10-16 18:22 ` Glenn Morris
@ 2014-10-16 18:42 ` Eli Zaretskii
2014-10-16 19:33 ` Paul Eggert
0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2014-10-16 18:42 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
> From: Glenn Morris <rgm@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Thu, 16 Oct 2014 14:22:01 -0400
>
>
> PS since the cursor blinks in 23.4, why does it not happen there?
I didn't look.
> Maybe timer--time-less-p "now" just using time-less-p is the cause?
No, it's seconds-to-time, which is called by timer-set-idle-time,
which in turn is called by run-with-idle-timer.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Pre-load time-date.el
2014-10-16 18:42 ` Eli Zaretskii
@ 2014-10-16 19:33 ` Paul Eggert
2014-11-17 4:45 ` Paul Eggert
0 siblings, 1 reply; 12+ messages in thread
From: Paul Eggert @ 2014-10-16 19:33 UTC (permalink / raw)
To: Eli Zaretskii, Glenn Morris; +Cc: emacs-devel
On 10/16/2014 11:42 AM, Eli Zaretskii wrote:
> it's seconds-to-time, which is called by timer-set-idle-time,
> which in turn is called by run-with-idle-timer.
>
It strikes me that low-level time primitives should accept counts of
seconds (either integers, or floats) in addition to the funky (HIGH LOW
USEC PSEC) format that they currently accept.This would be cheap to add
at the low level, and would remove the need for many calls to
seconds-to-time, including the abovementioned one, and would mean Emacs
wouldn't need to preload time-date.el. Also, doing the conversion in C
would lessen the amount of timing error introduced by the conversion itself.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Pre-load time-date.el
2014-10-16 19:33 ` Paul Eggert
@ 2014-11-17 4:45 ` Paul Eggert
0 siblings, 0 replies; 12+ messages in thread
From: Paul Eggert @ 2014-11-17 4:45 UTC (permalink / raw)
To: emacs-devel
Paul Eggert wrote:
> It strikes me that low-level time primitives should accept counts of seconds
> (either integers, or floats) in addition to the funky (HIGH LOW USEC PSEC)
> format that they currently accept.
I implemented something along these lines and installed it in the master as
0921dbc. This should fix the original problem, as time-date should no longer
need to be loaded for timers to work. (Of course it may have introduced new
problems....)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Pre-load time-date.el
2014-10-16 18:03 ` Glenn Morris
2014-10-16 18:22 ` Glenn Morris
@ 2014-10-16 18:24 ` Eli Zaretskii
2014-10-16 18:29 ` Glenn Morris
2014-10-16 20:08 ` Stefan Monnier
2 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2014-10-16 18:24 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
> From: Glenn Morris <rgm@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Thu, 16 Oct 2014 14:03:01 -0400
>
> Eli Zaretskii wrote:
>
> > Since we turn on blink-cursor mode by default, and it requires timers,
> > we now always load time-date.el at startup. Any reasons not to
> > pre-load it in loadup.el on the emacs-24 branch?
>
> This is not a new issue, right? It goes back to 24.1?
> And it causes no measurable harm?
> So why the rush to change it at the last minute?
Because I just noticed it now.
> (My fear would be that it somehow causes purespace overflow on some
> platform. Maybe that is totally unfounded?)
We could bump PURESIZE by the same amount as pre-loading this file
requires.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Pre-load time-date.el
2014-10-16 18:03 ` Glenn Morris
2014-10-16 18:22 ` Glenn Morris
2014-10-16 18:24 ` Eli Zaretskii
@ 2014-10-16 20:08 ` Stefan Monnier
2 siblings, 0 replies; 12+ messages in thread
From: Stefan Monnier @ 2014-10-16 20:08 UTC (permalink / raw)
To: Glenn Morris; +Cc: Eli Zaretskii, emacs-devel
>> Since we turn on blink-cursor mode by default, and it requires timers,
>> we now always load time-date.el at startup. Any reasons not to
>> pre-load it in loadup.el on the emacs-24 branch?
> This is not a new issue, right? It goes back to 24.1?
> And it causes no measurable harm?
> So why the rush to change it at the last minute?
> (My fear would be that it somehow causes purespace overflow on some
> platform. Maybe that is totally unfounded?)
Let's keep it for 24.5, it's not an urgent issue. Most of the times
I move something to loadup.el, I end up messing something up
(e.g. because the code uses defconst whose value gets purified, or
because I forget to update lisp.mk, or ...).
Stefan
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-11-17 4:45 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-16 16:47 Pre-load time-date.el Eli Zaretskii
2014-10-16 18:03 ` Glenn Morris
2014-10-16 18:22 ` Glenn Morris
2014-10-16 18:42 ` Eli Zaretskii
2014-10-16 19:33 ` Paul Eggert
2014-11-17 4:45 ` Paul Eggert
2014-10-16 18:24 ` Eli Zaretskii
2014-10-16 18:29 ` Glenn Morris
2014-10-16 18:51 ` Eli Zaretskii
2014-10-16 18:57 ` Eli Zaretskii
2014-10-16 19:01 ` Glenn Morris
2014-10-16 20:08 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).