From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Erik Selberg Newsgroups: gmane.emacs.devel Subject: Re: comint fix for shell colors Date: Fri, 18 Nov 2016 07:53:44 -0800 Message-ID: <5430A3E1-CD8B-4F1A-87BD-F1637BE3142A@selberg.org> References: <83twb5cd8t.fsf@gnu.org> <582f0f65.En4KsDnZnxPG7ZLy%wjenkner@inode.at> <83k2c0df63.fsf@gnu.org> <582f18f4.iBWOd+O4h9885qPS%wjenkner@inode.at> <83h974dcnw.fsf@gnu.org> <582f230b.H6hD/Dl//Y7pXQAi%wjenkner@inode.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1479484755 11886 195.159.176.226 (18 Nov 2016 15:59:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2016 15:59:15 +0000 (UTC) Cc: eliz@gnu.org, emacs-devel@gnu.org To: Wolfgang Jenkner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 18 16:59:12 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7lZH-0002Vv-TP for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 16:59:12 +0100 Original-Received: from localhost ([::1]:37520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7lZL-0002rC-7d for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 10:59:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7lU9-0006ge-3i for emacs-devel@gnu.org; Fri, 18 Nov 2016 10:53:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7lU8-0006gF-5c for emacs-devel@gnu.org; Fri, 18 Nov 2016 10:53:53 -0500 Original-Received: from mail-pg0-x231.google.com ([2607:f8b0:400e:c05::231]:35829) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7lU3-0006cV-BE; Fri, 18 Nov 2016 10:53:47 -0500 Original-Received: by mail-pg0-x231.google.com with SMTP id p66so104228518pga.2; Fri, 18 Nov 2016 07:53:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=EDE2ccmArM3Yt2k3qg3h/TrfuopsY844LMzSfe4QopQ=; b=Rhv1vmvnrRV+uYgYgkN1GG6oPWMWofc9DJrajzEMkCJCZRUZWr47bCLIowfBnBZ3TW 3H0fJqpdcEdN0+DpIHq0G7DhMLSNhxo7i5B28rLuUhQEgwLPeMbm9AwhXKTTMZwJrqfL evM1ROPzhOLb1utmrpIUc0G52P3BHrqHso1oQj4OgM8Ja3YQRN9q1axDP4SAB9av/vHs ZA9FcMvRGA9/h+Wd+dxt/8P147CrOJUmZS1Z3oT3Ku8QJDttF7ratb85hOY3fjCknOL9 jFXiHcTs0GZyLSXcuvs3BugEV8eF8URhGAAlKPaqS6Z+9gkI+ckwTYSg1E/9Zzw3lZxN sOTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:mime-version:subject:from:in-reply-to :date:cc:content-transfer-encoding:message-id:references:to; bh=EDE2ccmArM3Yt2k3qg3h/TrfuopsY844LMzSfe4QopQ=; b=HYT1KhHW/FP15i8gKDt3pV7vzHiK8rtBbUqdtTI5eVV5SJPHEhMe8oTCn6WnyVTjCf jFr90AG2B4SP7LU1qbgMa4W0hqZ/TP1pQpwJk9/p4znAfmboRE0Suw7QBy+clCKVQCAr VbBoHNK7nfE+1Z9RFiixKDiJb46zPZBFjK86QifDkb5BJQM1pAO/8K4hnq8UXUEpP5Au /kAgcS41N+eimNeyX7Z5INSbB0hd6xiGyA9ctDHYKe1sPZb53magZS6XKlW+nhdEj9gc xOp5Zlr0DoEDSsRTb37z2kmqKteqvNXLyDlFPm/mXAR8g0MqZSkhmjm48MUhw0HfrA9t zQaw== X-Gm-Message-State: AKaTC03kLv8sOGsVjPthn6uO8SwGtqaW2iVnC5+ld0Qc61/DPSPDA0xZRlSi1w8A3pZM0Q== X-Received: by 10.99.170.14 with SMTP id e14mr696059pgf.119.1479484425845; Fri, 18 Nov 2016 07:53:45 -0800 (PST) Original-Received: from [192.168.0.226] (71-212-117-24.tukw.qwest.net. [71.212.117.24]) by smtp.gmail.com with ESMTPSA id f132sm2661912pfa.72.2016.11.18.07.53.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Nov 2016 07:53:45 -0800 (PST) X-Mailer: iPhone Mail (14B150) In-Reply-To: <582f230b.H6hD/Dl//Y7pXQAi%wjenkner@inode.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209483 Archived-At: I see fixed in 25.1. Thx ill give that a look-see. Cheers, -e Sent from my iPhone > On Nov 18, 2016, at 7:49 AM, Wolfgang Jenkner wrote: >=20 > Eli Zaretskii wrote: >=20 >>> Date: Fri, 18 Nov 2016 16:06:28 +0100 >>> From: Wolfgang Jenkner >>> Cc: erik@selberg.org, emacs-devel@gnu.org >>>=20 >>>> Indeed, I think this change should be described in NEWS. Could you >>>> provide a patch for that, please? >>>=20 >>> Please note that there's nothing new here, it was just a bug fix. >>> The very first message in the bug report mentioned above states >>>=20 >>> In Emacs 24.3, comint-highlight-prompt allows ANSI colors to show= through >>> if it does not specify any colors itself. In Emacs 24.4, it does n= ot, even >>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>> if comint-highlight-prompt is the "empty face". >>=20 >> Then how do you explain the OP's confusion on this matter? >=20 > He said that he "made the following patch against 24.5", so I guess > that's what he runs and that release still had the regression > reported in bug#20084 (see my closing message there). >=20 > Wolfgang >=20 >=20