From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: master f51f963: Fix some side-effecting uses of make-text-button Date: Sat, 6 Jun 2020 13:19:35 -0700 (PDT) Message-ID: <54301e3c-35a1-4f01-bf66-b7dfeeddecd2@default> References: <20200604223056.17078.81265@vcs0.savannah.gnu.org> <20200604223058.1850020A26@vcs0.savannah.gnu.org> <87eeqtiy4x.fsf@tcd.ie> <3325df83-4840-c15d-3f38-372628a54536@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="108572"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Paul Eggert , Stefan Monnier , "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 06 22:20:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhfJ2-000S9m-1t for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jun 2020 22:20:40 +0200 Original-Received: from localhost ([::1]:40620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhfJ1-0001tx-1Z for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jun 2020 16:20:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhfI9-000141-Vg for emacs-devel@gnu.org; Sat, 06 Jun 2020 16:19:46 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:46042) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhfI9-00007k-33 for emacs-devel@gnu.org; Sat, 06 Jun 2020 16:19:45 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 056KIQwH064101; Sat, 6 Jun 2020 20:19:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=+XWvdX2GfXkhLSy5pZpVcPLIo+5vzDpLZYAD9XU0IUQ=; b=JL//GvMEIWLuMT2oxLSI9v8VXi7ih/bLx0hNbJLcWJ6dj/vHP/9vtKO50Coafap9tidF oQ/xY66tt4lrAt3EDCQaUsGFc3+C+QM4b7CGDo5Zt33mWUuDLbvB5duSGQrHpAY69Gtb 3Gc1dfMXPtdQW4/bwC09YTIpEwxNN9WkkeQvw2wZEFLvdumOMadwjXFcNVTsyMMgXabY iOtsfL4Mwt7VxzgKohWjT7hBh5reabwf52NAqy6eJlmctJrtNRWFBssbh4DQzoFSf1Of x5fuQQAleaJRt+rWxTrMIV03nbCKldJ9CPcHUvo5p55XnGBVU3e9BKmtNDmyeTg0PVlk VA== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 31g2jqsthn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 06 Jun 2020 20:19:43 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 056KHkKC091840; Sat, 6 Jun 2020 20:19:43 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 31g08r8d2n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 06 Jun 2020 20:19:43 +0000 Original-Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 056KJden014341; Sat, 6 Jun 2020 20:19:39 GMT In-Reply-To: <3325df83-4840-c15d-3f38-372628a54536@cs.ucla.edu> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5005.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9644 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 malwarescore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006060162 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9644 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 impostorscore=0 cotscore=-2147483648 priorityscore=1501 spamscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006060162 Received-SPF: pass client-ip=156.151.31.86; envelope-from=drew.adams@oracle.com; helo=userp2130.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/06 16:19:14 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251969 Archived-At: > > So, IIUC `make-text-button` should ideally work functionally, but for > > historical reasons it works by side-effect. What's the long term plan? > > Do we plan to live with the current side-effecting behavior, or do we > > plan to move to the "pure" functional behavior? >=20 > Given the comments in this thread it seems that there's consensus that it > should move to the "pure" functional behavior, as the side-effecting beha= vior is > confusing (and this is independent of whether string literals are constan= t). Please don't count me among the consenting, in your consensus count. > I installed the attached patch, which is along the lines that I proposed = a > couple of days ago; it has the doc fix that Pip Cet suggested. What was the reason not to go the other direction, and _always allow_ modification of that string arg?