From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Preferring ptrdiff_t to ssize_t Date: Wed, 01 Oct 2014 21:04:20 -0700 Organization: UCLA Computer Science Department Message-ID: <542CCEC4.5050101@cs.ucla.edu> References: <542C6434.8020505@cs.ucla.edu> <83zjdfi3kn.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1412222721 24977 80.91.229.3 (2 Oct 2014 04:05:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 2 Oct 2014 04:05:21 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 02 06:05:14 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XZXdi-0005YJ-1j for ged-emacs-devel@m.gmane.org; Thu, 02 Oct 2014 06:05:14 +0200 Original-Received: from localhost ([::1]:60021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZXdh-0005Fx-L8 for ged-emacs-devel@m.gmane.org; Thu, 02 Oct 2014 00:05:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZXdL-0005FV-58 for emacs-devel@gnu.org; Thu, 02 Oct 2014 00:04:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZXdD-0003mM-I9 for emacs-devel@gnu.org; Thu, 02 Oct 2014 00:04:51 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:41598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZXd5-0003lJ-FW; Thu, 02 Oct 2014 00:04:35 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 1466C39E8017; Wed, 1 Oct 2014 21:04:34 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nI8PzNwN8jEM; Wed, 1 Oct 2014 21:04:25 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-71-177-17-123.lsanca.dsl-w.verizon.net [71.177.17.123]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 610CA39E8012; Wed, 1 Oct 2014 21:04:25 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 In-Reply-To: <83zjdfi3kn.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:174926 Archived-At: Eli Zaretskii wrote: > The value in question is being > passed to realloc, which accepts an argument of type size_t. I needed > a signed type of the same width, so I've chosen ssize_t. ssize_t is not necessarily the same width as size_t. Since the variable's initializer is of type 'int', how about simply declaring the variable to be 'int' as well? That would avoid confusion caused by ssize_t's appearing out of the blue, and would fit better with Emacs's general preference for using the type 'int' for smallish integer values. > I wish you'd discuss these issues before making changes The issue is so minor it didn't seem worth discussing. I assumed you thought so too, as your recent change introduced ssize_t there without discussing the matter either. But as you say, this point is moot now.