unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Tassilo Horn <tsdh@gnu.org>
Cc: Garjola Dindi <garjola@garjola.net>, emacs-devel@gnu.org
Subject: Re: Proposing changes to adjust_frame_size
Date: Wed, 12 May 2021 10:44:37 +0200	[thread overview]
Message-ID: <54259dfb-3ca4-f3b0-8344-f3de5106d286@gmx.at> (raw)
In-Reply-To: <87sg2tr4u4.fsf@gnu.org>

 > 11:15 <tsdh> Does it support resize requests?  What happens when you make an
 >               already visible frame invisible or iconified?  Does it support
 >               size hints?
 > 11:15 <tsdh> "it" is sway, and frame = WM window.
 > 11:16 <emersion> resize requests: yes

Funny.  I would say that

if (!container_is_floating(view->container)) {
		return;
	}

from the URL below should say "no" but maybe I'm missing something.  Can
you change the size of a frame by setting its 'width' or 'height'
parameter?  Does your frame resize when you toggle the vertical scroll
bar on/off?

 > 11:16 <emersion> size hints: yes

We'll look into that, eventually.

 > 11:16 <emersion> iconified: iirc that does nothing
 > 11:16 <emersion> but not sure
 > 11:16 <emersion> all of this assumes an x11 client
 > 11:17 <tsdh> emersion: Yes, right now, emacs is an x11 client (GTK3 built).
 > 11:18 <tsdh> What does sway when a new emacs frame should be mapped and
 >               requests a certain size?  It's at least not honored in tiling
 >               mode which is obviously fine.
 > 11:25 <emersion> https://github.com/swaywm/sway/blob/31b4b96ebf2af88630752d8518fd360ff84cf3e5/sway/desktop/xwayland.c#L584
 > 11:28 <tsdh> Thanks!
 > --8<---------------cut here---------------end--------------->8---
 >
 >> ... and this is our usual annoyance.  I attached a new patch which
 >> should handle these cases as well.  If there's anything else left,
 >> please tell me.
 >
 > The new version handles all cases we've had so far.  Thanks!

I've pushed it now.  It should fail in the usual manner with

(setq frame (make-frame '((visibility . nil) (width . 80))))
(make-frame-visible frame)

Please verify.

And many thanks for testing, martin



  reply	other threads:[~2021-05-12  8:44 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-25 17:11 Proposing changes to adjust_frame_size martin rudalics
2021-04-27  8:22 ` martin rudalics
2021-04-27 14:16   ` Yuuki Harano
2021-05-02  8:46     ` martin rudalics
2021-05-02 11:21       ` Alan Third
2021-05-02 16:17         ` martin rudalics
2021-05-05  8:51       ` martin rudalics
2021-05-05 10:47         ` Yuuki Harano
2021-05-05 11:24           ` martin rudalics
2021-05-05 14:07             ` Yuuki Harano
2021-05-05 15:01               ` martin rudalics
2021-05-05 16:45                 ` martin rudalics
2021-05-05 18:54                   ` Tassilo Horn
2021-05-06  7:44                     ` martin rudalics
2021-05-06  7:59                       ` Tassilo Horn
2021-05-06  8:39                         ` martin rudalics
2021-05-06  8:49                           ` Tassilo Horn
2021-05-06 12:10                             ` martin rudalics
2021-05-06 12:31                               ` Tassilo Horn
2021-05-06 14:10                                 ` martin rudalics
2021-05-06 14:47                                   ` Tassilo Horn
2021-05-07  8:03                                     ` martin rudalics
2021-05-08  7:02                                       ` Tassilo Horn
2021-05-08  7:16                                         ` martin rudalics
2021-05-08 14:03                                           ` Tassilo Horn
2021-05-08 15:17                                             ` martin rudalics
2021-05-08 20:32                                               ` Tassilo Horn
2021-05-09  8:41                                                 ` martin rudalics
2021-05-09 10:09                                                   ` Garjola Dindi
2021-05-09 10:12                                                   ` Garjola Dindi
2021-05-09 18:48                                                   ` Tassilo Horn
2021-05-10  8:25                                                     ` martin rudalics
2021-05-10 12:27                                                       ` martin rudalics
2021-05-10 19:05                                                         ` Tassilo Horn
2021-05-10 19:21                                                           ` martin rudalics
2021-05-10 19:28                                                             ` Tassilo Horn
2021-05-11  8:29                                                               ` martin rudalics
2021-05-11  9:25                                                                 ` Tassilo Horn
2021-05-12  8:44                                                                   ` martin rudalics [this message]
2021-05-12 14:53                                                                     ` Tassilo Horn
2021-05-12 16:40                                                                       ` martin rudalics
2021-05-12 19:06                                                                         ` Tassilo Horn
2021-05-13  7:55                                                                           ` martin rudalics
2021-05-13  8:08                                                                             ` Tassilo Horn
2021-05-16  8:29                                                                               ` martin rudalics
2021-05-16  8:33                                                                                 ` Tassilo Horn
2021-05-16  9:14                                                                                   ` martin rudalics
2021-05-16  9:16                                                                                     ` Tassilo Horn
2021-05-16 12:24                                                                                       ` martin rudalics
2021-05-16 19:08                                                                                         ` Tassilo Horn
2021-05-17  7:33                                                                                           ` martin rudalics
2021-05-06 14:41                   ` Yuuki Harano
2021-05-09  9:32                     ` Yuuki Harano
2021-05-09 13:47                       ` martin rudalics
2021-05-09 15:30                         ` Yuuki Harano
2021-05-10  8:24                           ` martin rudalics
2021-05-10 13:18                             ` Yuuki Harano
2021-05-10 14:16                               ` martin rudalics
2021-05-10 15:41                                 ` Yuuki Harano
2021-05-10 19:20                                   ` martin rudalics
2021-05-11 14:32                                     ` Yuuki Harano
2021-05-12  8:47                                       ` martin rudalics
2021-05-13  8:48                                         ` Garjola Dindi
2021-05-01 18:59 ` Alan Third
2021-05-02  7:38   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54259dfb-3ca4-f3b0-8344-f3de5106d286@gmx.at \
    --to=rudalics@gmx.at \
    --cc=emacs-devel@gnu.org \
    --cc=garjola@garjola.net \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).