From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Trunk emacs infelicity with linum mode Date: Thu, 11 Sep 2014 18:40:09 +0200 Message-ID: <5411D069.5020007@gmx.at> References: <87zjeix7hg.fsf@glaurung.internal.golden-gryphon.com> <838um1gar9.fsf@gnu.org> <87ppfdyhpf.fsf@glaurung.internal.golden-gryphon.com> <8361h5g7mv.fsf@gnu.org> <87zjehw5cs.fsf@glaurung.internal.golden-gryphon.com> <834mwog0u0.fsf@gnu.org> <87wq9kd5y3.fsf@glaurung.internal.golden-gryphon.com> <83oauve75i.fsf@gnu.org> <87lhpxaopi.fsf@glaurung.internal.golden-gryphon.com> <83vbp1deta.fsf@gnu.org> <540ACB6A.5020402@gmx.at> <540AED8A.9030000@gmx.at> <83ha0jcv31.fsf@gnu.org> <540C9F76.2020606@gmx.at> <831trncjhf.fsf@gnu.org> <540D7793.6010704@gmx.at> <83mwa9aqdq.fsf@gnu.org> <541005DC.9060704@gmx.at> <83a9679xyf.fsf@gnu.org> <5410A059.9000102@gmx.at> <831trj9tip.fsf@gnu.org> <83zje78ei7.fsf@gnu.org> <54116AA8.1040503@gmx.at> <83oaum8a0e.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1410453670 26395 80.91.229.3 (11 Sep 2014 16:41:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Sep 2014 16:41:10 +0000 (UTC) Cc: srivasta@ieee.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 11 18:41:01 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XS7QY-0002RU-MJ for ged-emacs-devel@m.gmane.org; Thu, 11 Sep 2014 18:40:58 +0200 Original-Received: from localhost ([::1]:40015 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS7QY-00056x-9w for ged-emacs-devel@m.gmane.org; Thu, 11 Sep 2014 12:40:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS7QE-00056f-O3 for emacs-devel@gnu.org; Thu, 11 Sep 2014 12:40:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XS7Q7-00025Z-7B for emacs-devel@gnu.org; Thu, 11 Sep 2014 12:40:38 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:52795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS7Py-00023I-ON; Thu, 11 Sep 2014 12:40:23 -0400 Original-Received: from [88.117.61.137] ([88.117.61.137]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0M5tU1-1YGE803oHB-00xqBF; Thu, 11 Sep 2014 18:40:18 +0200 In-Reply-To: <83oaum8a0e.fsf@gnu.org> X-Provags-ID: V03:K0:IMAuljdNoTTj4eZIjLUP72o41MTrN22jQWBqPLaI4FhKz6khRNd ocHX27BekKDA4nfgE4w8wEHonWjqX4U2bRPfrYjvCNW+pbnSRvznmDtAuL1jbEXQsSRy4HJ cZ1uKMd5saVepDcg1gOPWkEfk+rEQQ4hIj6lpSi7L/fxJrMQiSzNjlBAVnMktPF+6kyhvfl UYl66d2YTA1dz+uvnrL+A== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:174183 Archived-At: >> > If I set a breakpoint in Fface_font, which is what barfed in the OP's >> > case, the breakpoint doesn't break inside the call to >> > adjust_frame_size or Fx_create_frame, it breaks after Fx_create_frame >> > already returned. I don't know why the difference. >> >> I suppose the OP confused two calls of adjust_frame_size - the one at >> line 4609 and the one at line 4678. > > Or maybe we confused that. We won't be able to tell but among the values he posted we have an old_text_width of 10 which is inherently incompatible with a call from line 4678 and a frame column width of 9. > Probably because of the tool bar or the scroll bars -- these are the > only differences between the builds, AFAIR. The tool bar is set before calling x_figure_window_size so I suspect it's the scroll bar height call which in adjust_frame_size already sets all values just as the change_frame_size callback triggered by the call on line 4678 wants them. This would explain that the hook is _not_ triggered by the call on line 4678. It doesn't explain why it's triggered on Motif/Lucid where I basically "do the same thing" (though apparently I don't). > What will break if we set f->official true only _after_ the second > adjust_frame_size returns? Nothing, I presume. More so, because the fact that the hook is not triggered on Windows and Gtk, already constitutes a bug which makes the use of the hook during frame setup impractical on these systems. Note, however, that the hook might still trigger any time in between setting f->official and executing (face-set-after-frame-default frame parameters) though currently I can't see how that could happen. martin