unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Cédric Chépied" <cedric.chepied@gmail.com>
To: Kelvin White <kwhite@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: ERC: [PATCH] use network name for server buffer name
Date: Fri, 25 Jul 2014 08:32:55 +0200	[thread overview]
Message-ID: <53d1fa19.e55bc20a.255f.42a7@mx.google.com> (raw)
In-Reply-To: <874my72avb.wl%kwhite@gnu.org>

At Thu, 24 Jul 2014 08:35:04 -0400,
Kelvin White wrote:
> 
> 
> This change mainly affects users that may connect to the same server
> multiple times for multiple networks. e.g. bouncers like ZNC or proxy
> users. In these cases a user will have multiple server-buffers with
> the same name (i.e. irc.example.net:6697, irc.example.net:6697<2> etc.)
> This patch will rename the server-buffer to whatever the network name
> is, if available. Otherwise, the hostname:port will be used as normal.
> 
> === modified file 'lisp/erc/erc.el'
> --- lisp/erc/erc.el     2014-07-08 19:45:24 +0000
> +++ lisp/erc/erc.el     2014-07-24 12:25:24 +0000
> @@ -6233,7 +6233,9 @@
>      (cond ((erc-default-target)
>             (concat (erc-string-no-properties (erc-default-target))
>                     "@" network-name))
> -          (network-name network-name)
> +          (network-name
> +           (rename-buffer network-name)
> +           network-name)
>            (t (buffer-name (current-buffer))))))
> 

I had another problem but quite similar. I'm using znc to connect to several
network and sometimes I speak to people with the same nick but on different
network so I rewrited the erc-get-buffer-create function. Network name is
appended at the end of buffer name. Sorry I have no patch for this, only the
code:

(defun erc-get-buffer-create (server port target)
  "Create a new buffer based on the arguments."
  (setq target (concat target "@" (prin1-to-string (erc-current-network))))
  (get-buffer-create (erc-generate-new-buffer-name server port target)))

It is not perfect because for server buffers I have "@nil", "@nil<1>", ... but
it works great for channels or private messages.
-- 
Cédric Chépied
<cedric.chepied@gmail.com>



  reply	other threads:[~2014-07-25  6:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 12:35 ERC: [PATCH] use network name for server buffer name Kelvin White
2014-07-25  6:32 ` Cédric Chépied [this message]
2014-07-25 16:11   ` Mirek Kaim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53d1fa19.e55bc20a.255f.42a7@mx.google.com \
    --to=cedric.chepied@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=kwhite@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).