From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f18af6c: Audit use of lsh and fix glitches Date: Wed, 22 Aug 2018 09:35:53 -0400 Message-ID: <53d0c06e-2383-955a-0a17-650fd842b483@cornell.edu> References: <20180821204437.16880.99611@vcs0.savannah.gnu.org> <20180821204439.62390209A6@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1534944889 2764 195.159.176.226 (22 Aug 2018 13:34:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Aug 2018 13:34:49 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 To: Pip Cet , emacs-devel@gnu.org, eggert@cs.ucla.edu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 22 15:34:45 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsTHX-0000Yz-De for ged-emacs-devel@m.gmane.org; Wed, 22 Aug 2018 15:34:43 +0200 Original-Received: from localhost ([::1]:59139 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsTJc-0005uP-JS for ged-emacs-devel@m.gmane.org; Wed, 22 Aug 2018 09:36:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsTIy-0005u9-4g for emacs-devel@gnu.org; Wed, 22 Aug 2018 09:36:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsTIp-00074Y-Qn for emacs-devel@gnu.org; Wed, 22 Aug 2018 09:36:11 -0400 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:39042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsTIp-00073N-Ly for emacs-devel@gnu.org; Wed, 22 Aug 2018 09:36:03 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w7MDZsws026413; Wed, 22 Aug 2018 09:35:54 -0400 Original-Received: from [192.168.0.4] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w7MDZq6a013006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 22 Aug 2018 09:35:53 -0400 In-Reply-To: Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 128.84.13.243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228806 Archived-At: On 8/22/2018 8:36 AM, Pip Cet wrote: > On Tue, Aug 21, 2018 at 9:01 PM Paul Eggert wrote: >> * lisp/vc/vc-hg.el (vc-hg-state-fast): When testing fixnum width, >> prefer (zerop (ash most-positive-fixnum -32)) to (zerop (lsh -1 >> 32)) (Bug#32485#11). > > I think the previous code was correct: now we have bignums, we should > no longer return 'unsupported on machines with 30/32-bit fixnums, I think you're missing the point of that code. The function is vc-hg-state-fast. If it returns 'unsupported, that simply means that the slower function will be used. Ken