From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Changes in frame/window code Date: Wed, 20 Aug 2014 17:32:11 +0200 Message-ID: <53F4BF7B.8000402@gmx.at> References: <53CE6A44.1010708@gmx.at> <838undgxiu.fsf@gnu.org> <53D76758.2030707@gmx.at> <831tt4h58x.fsf@gnu.org> <83y4vcfoqi.fsf@gnu.org> <53D77BDB.1090500@gmx.at> <83wqawflgj.fsf@gnu.org> <53D7A981.30909@gmx.at> <83lhrctdzr.fsf@gnu.org> <53D7C10C.4010402@gmx.at> <83k36wta5m.fsf@gnu.org> <53D7E6B0.7040504@gmx.at> <83egx4t3nq.fsf@gnu.org> <53D917B5.2050604@gmx.at> <837g2uu80w.fsf@gnu.org> <53D9211C.7010000@gmx.at> <834mxyu5jg.fsf@gnu.org> <53D92D04.3010006@gmx.at> <83zjfqspfw.fsf@gnu.org> <53DA0310.4010706@gmx.at> <53DA15C4.5050006@gmx.at> <83mwbpss6s.fsf@gnu.org> <53DA29EC.3000504@gmx.at> <837g2ssg30.fsf@gnu.org> <53DB6B08.7000305@gmx.at> <834mxws6a0.fsf@gnu.org> <53DBB268.2020909@gmx.at> <831tt0rwyp.fsf@gnu.org> <53EE2CD5.50603@gmx.a> <83tx5demej.fsf@gnu.org> <53EF25F2.9010909@gmx.at> <83iolsekqd.fsf@gnu.org> <53EF609C.2090303@gmx> <83wqa7cfoy.fsf@gnu.org> <53F1B9EA.6030808@gmx.at> <83lhqldeqf.fsf@gnu.org> <53F225A7.6030103@gmx.at> <83ha19day1.fsf@gnu.org> <83bnrgcxxt.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1408548787 20182 80.91.229.3 (20 Aug 2014 15:33:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Aug 2014 15:33:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 20 17:33:00 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XK7sX-0003nf-RL for ged-emacs-devel@m.gmane.org; Wed, 20 Aug 2014 17:32:49 +0200 Original-Received: from localhost ([::1]:56305 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK7sX-0002uY-Bh for ged-emacs-devel@m.gmane.org; Wed, 20 Aug 2014 11:32:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK7sC-0002uK-NX for emacs-devel@gnu.org; Wed, 20 Aug 2014 11:32:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XK7s5-0001KV-6R for emacs-devel@gnu.org; Wed, 20 Aug 2014 11:32:28 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:63625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK7s4-0001JW-RE; Wed, 20 Aug 2014 11:32:21 -0400 Original-Received: from [178.191.140.69] ([178.191.140.69]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0Lg6op-1WaYKP3lnv-00pbTl; Wed, 20 Aug 2014 17:32:19 +0200 In-Reply-To: <83bnrgcxxt.fsf@gnu.org> X-Provags-ID: V03:K0:Duuz3+FE7/dKwqcm4AUFV9NfV24ILWUfbU5fao03f1jZBtW94X0 SYmsaQAGKlko07eEAs97bitqJ5fucCBaGmbW4eFthvlcIx6i7lAQJUUZawXtwkvefOam0+9 6FsT/CexfFvv5BRtf/rod0GV6KlfJFT1AksjkilF53z7EVilKsr2IU74396WacWY/yOn4nS QJ/nTbQ7WaL1au1G2gI5Q== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173779 Archived-At: > I found the reason for this: w32_horizontal_scroll_bar_handle_click > reported bogus (always -1) values in the Y part of '(X . Y)' member of > the click event, when I drag the thumb. That value is not used in L2R > paragraphs, so L2R buffers were not affected. I noticed the -1 but attributed it to the fact that I made the thumb larger by one and decided to take care of this later. I wouldn't have suspected this to be the root of almost all evil and would probably have spent another week looking elsewhere. > This is now fixed in trunk r117715. Thanks. I'll now take care of the other builds. > Btw, I don't understand why in w32_horizontal_scroll_bar_handle_click > you overwrite the value reported from GetScrollInfo by > HIWORD(msg->msg.wParam). My reading of MSDN documentation is that > they recommend to do it the other way around, since GetScrollInfo is > not limited to 16-bit values. If using the values reported by > GetScrollInfo doesn't work well, perhaps that's because for > SB_THUMBTRACK message you need to use SIF_TRACKPOS and si.nTrackPos > rather than SIF_POS and si.nPos. I first took everything verbatim from the vertical routines and then changed what I considered necessary for the horizontal part. This specific part obviously remained unchanged. martin