unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Colascione <dancol@dancol.org>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r117534: Unbreak compilation of derived cc-mode modes
Date: Mon, 14 Jul 2014 21:05:05 -0700	[thread overview]
Message-ID: <53C4A871.8030702@dancol.org> (raw)
In-Reply-To: <lofvi3gu52.fsf@fencepost.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

On 07/14/2014 08:47 PM, Glenn Morris wrote:
> Daniel Colascione wrote:
> 
>> --- a/lisp/progmodes/cc-defs.el	2014-06-29 11:26:47 +0000
>> +++ b/lisp/progmodes/cc-defs.el	2014-07-14 23:58:52 +0000
> [...]
>> @@ -1946,7 +1943,7 @@
>>  	;; reason, but we also use this expansion handle
>>  	;; `c-lang-defconst-eval-immediately' and to register
>>  	;; dependencies on the `c-lang-const's in VAL.)
>> -	(setq val (cl-macroexpand-all val))
>> +	(setq val (macroexpand-all val))
>>  
>>  	(setq bindings (cons (cons assigned-mode val) bindings)
>>  	      args (cdr args))))
> 
> Why is this needed, when cc-defs requires cl at compile time,
> which defines cl-macroexpand-all as an alias for macroexpand-all?

I was trying to fix some code that broke when requiring cc-langs and
cc-fonts only. Requiring these features doesn't bring the needed alias,
but apparently used to:

ELISP> (require 'cc-langs)
cc-langs
ELISP> (require 'cc-fonts)
cc-fonts
ELISP> (featurep 'cl)
nil

Maybe that's the real bug.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

  reply	other threads:[~2014-07-15  4:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1X6q9D-0003AI-D2@vcs.savannah.gnu.org>
2014-07-15  3:47 ` trunk r117534: Unbreak compilation of derived cc-mode modes Glenn Morris
2014-07-15  4:05   ` Daniel Colascione [this message]
2014-07-15  6:00     ` Glenn Morris
2014-07-15  6:19       ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C4A871.8030702@dancol.org \
    --to=dancol@dancol.org \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).