From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r117464: Shrink Lisp_Sub_Char_Table by preferring C integers to Lisp_Objects. Date: Thu, 03 Jul 2014 21:01:59 +0400 Message-ID: <53B58C87.1080109@yandex.ru> References: <53B42194.2040003@yandex.ru> <53B42B2E.7090404@yandex.ru> <53B4D81E.6010904@yandex.ru> <53B57898.6080003@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1404406948 2786 80.91.229.3 (3 Jul 2014 17:02:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Jul 2014 17:02:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 03 19:02:21 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X2kOq-0007Rz-Au for ged-emacs-devel@m.gmane.org; Thu, 03 Jul 2014 19:02:20 +0200 Original-Received: from localhost ([::1]:60898 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2kOp-0004TO-TE for ged-emacs-devel@m.gmane.org; Thu, 03 Jul 2014 13:02:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2kOg-0004SB-1u for emacs-devel@gnu.org; Thu, 03 Jul 2014 13:02:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2kOZ-0002Ym-0Z for emacs-devel@gnu.org; Thu, 03 Jul 2014 13:02:09 -0400 Original-Received: from forward8l.mail.yandex.net ([84.201.143.141]:58260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2kOY-0002Yb-Nc for emacs-devel@gnu.org; Thu, 03 Jul 2014 13:02:02 -0400 Original-Received: from smtp2h.mail.yandex.net (smtp2h.mail.yandex.net [84.201.187.145]) by forward8l.mail.yandex.net (Yandex) with ESMTP id 4B8E01A41AAF; Thu, 3 Jul 2014 21:02:00 +0400 (MSK) Original-Received: from smtp2h.mail.yandex.net (localhost [127.0.0.1]) by smtp2h.mail.yandex.net (Yandex) with ESMTP id CF6CD170505E; Thu, 3 Jul 2014 21:01:59 +0400 (MSK) Original-Received: from unknown (unknown [37.139.80.10]) by smtp2h.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id IhzX4joy5v-1xDucOKf; Thu, 3 Jul 2014 21:01:59 +0400 (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client certificate not present) X-Yandex-Uniq: 5daf6075-637c-496b-b5dc-caa0f905691b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1404406919; bh=XEXgOS0JJM8fkItuJsCJpb3TyTUqDs/Xvmzl8stnGJI=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=dhwfiwulk2U8HCHNb3gTfZBRhLXaaeGzWPMtykLDF0ugp9XxseY1xU59TxsrtIPCL 5C3QPQfGX2keQOtjaEptgAIBdB48ImkZqduMuFeJOzYn/c5qy/XAmEznX3H780tovn K/oIvMuFM0unmoB5PTJSvBs2Ydo8vcT8VGEwkTnM= Authentication-Results: smtp2h.mail.yandex.net; dkim=pass header.i=@yandex.ru User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 84.201.143.141 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172872 Archived-At: On 07/03/2014 08:49 PM, Stefan Monnier wrote: > Could you try to use something like the patch below to eliminate this > alignment assumption? > > === modified file 'src/alloc.c' > --- src/alloc.c 2014-07-02 03:26:19 +0000 > +++ src/alloc.c 2014-07-03 16:47:25 +0000 > @@ -5962,13 +5962,18 @@ > { > int size = ptr->header.size & PSEUDOVECTOR_SIZE_MASK; > /* Consult the Lisp_Sub_Char_Table layout before changing this. */ > - int i, idx = (pvectype == PVEC_SUB_CHAR_TABLE ? SUB_CHAR_TABLE_OFFSET : 0); > + int i; > + Lisp_Object *contents > + = pvectype == PVEC_SUB_CHAR_TABLE > + ? (size -= SUB_CHAR_TABLE_OFFSET, > + ((struct Lisp_Sub_Char_Table *)ptr)->contents) > + : ((struct Lisp_Char_Table *)ptr)->contents; This is obviously wrong because Lisp_Object slots of Lisp_Char_Table between 'header' and 'contents' are never marked. This code should looks like: Lisp_Object *contents = pvectype == PVEC_SUB_CHAR_TABLE ? (size -= SUB_CHAR_TABLE_OFFSET, ((struct Lisp_Sub_Char_Table *)ptr)->contents) : ptr->contents; And, IIUC, 'size -= SUB_CHAR_TABLE_OFFSET' still assumes that SUB_CHAR_TABLE_OFFSET is a multiple of sizeof (Lisp_Object) (otherwise subtracting it from size, which is a number of Lisp_Object slots, makes no sense). Dmitry