From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: trunk r117396: Do not allow out-of-range character position in Fcompare_strings. Date: Wed, 25 Jun 2014 19:57:40 +0400 Message-ID: <53AAF174.40002@yandex.ru> References: <86wqc5kttw.fsf@yandex.ru> <53AAD2A6.5060705@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1403711892 1945 80.91.229.3 (25 Jun 2014 15:58:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Jun 2014 15:58:12 +0000 (UTC) Cc: Dmitry , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 25 17:58:03 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WzpaE-0006IB-Di for ged-emacs-devel@m.gmane.org; Wed, 25 Jun 2014 17:58:02 +0200 Original-Received: from localhost ([::1]:38961 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpaD-00024j-Mh for ged-emacs-devel@m.gmane.org; Wed, 25 Jun 2014 11:58:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wzpa3-00024Y-Lo for emacs-devel@gnu.org; Wed, 25 Jun 2014 11:57:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzpZw-0001Tt-3K for emacs-devel@gnu.org; Wed, 25 Jun 2014 11:57:51 -0400 Original-Received: from forward8l.mail.yandex.net ([84.201.143.141]:34814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzpZv-0001TZ-Qn for emacs-devel@gnu.org; Wed, 25 Jun 2014 11:57:44 -0400 Original-Received: from smtp12.mail.yandex.net (smtp12.mail.yandex.net [95.108.131.191]) by forward8l.mail.yandex.net (Yandex) with ESMTP id 645F51A41849; Wed, 25 Jun 2014 19:57:41 +0400 (MSK) Original-Received: from smtp12.mail.yandex.net (localhost [127.0.0.1]) by smtp12.mail.yandex.net (Yandex) with ESMTP id 0E77916A0198; Wed, 25 Jun 2014 19:57:40 +0400 (MSK) Original-Received: from unknown (unknown [37.139.80.10]) by smtp12.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id sKE2kdVSPT-vegm7xYf; Wed, 25 Jun 2014 19:57:40 +0400 (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client certificate not present) X-Yandex-Uniq: f7094420-cd84-43c6-afe6-031f08ee0cfb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1403711860; bh=kZFHVW6gIg7vmoILKkS55foYmlqZ9VrxtaFe+GcJLGM=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=eE/XcVv3skIPyz/U2GcAYC/1O7ZL0hPtz1FF3e0EkHqKBpIuDSUVmIDSnFQzAykEQ e5uaHKzHMJrN19ON59c/JicFwSJ0b1ii3oR+QygaAWc1n7E/1XOVoHgx075vJybouZ cCUJmMma6ciCYl6UPVyyzOtDuSI8YH8Lhr0UyMec= Authentication-Results: smtp12.mail.yandex.net; dkim=pass header.i=@yandex.ru User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 84.201.143.141 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172705 Archived-At: On 06/25/2014 07:17 PM, Stefan Monnier wrote: > That was a misunderstanding: the discussion has never been about > emacs-24 AFAICT since it's not about fixing a bug. May be I just misunderstood the development/release process as a whole, but what "it's too late" means for the trunk? > We don't have the behavior for aref, but we do have it for nth and > gethash and people frequently rely on this behavior. Hm...lists are mutable - you can concatenate A and B (with setcdr) and get changed A but not the copy of A + B. On the other side, I always consider strings and vectors as "less mutable", which implies more strict checking (as with aref and aset). > Now that it's installed, I guess we can try to run with it for a while, > but I expect we'll get many bug reports from it because external > packages rely on that behavior (just like bundled packages relied on it, > or even more so since many external packages don't use string-prefix-p > because it didn't exist back then). In ELPA, I don't see too much users of compare-strings: $ grep -nHR "(compare-strings " . packages/company/company.el:1093: (not (eq t (compare-strings (car candidates) nil nil packages/vlf/vlf-ediff.el:323: (eq t (compare-strings suffix nil nil string start-pos nil packages/gnugo/gnugo.el:290: (compare-strings s1 beg1 nil s2 beg2 nil)) I can check other external packages as well. Emacspeak? Dmitry