From: Dmitry Antipov <dmantipov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Dmitry <dgutov@yandex.ru>, emacs-devel@gnu.org
Subject: Re: trunk r117396: Do not allow out-of-range character position in Fcompare_strings.
Date: Wed, 25 Jun 2014 19:57:40 +0400 [thread overview]
Message-ID: <53AAF174.40002@yandex.ru> (raw)
In-Reply-To: <jwva991t4c1.fsf-monnier+emacs@gnu.org>
On 06/25/2014 07:17 PM, Stefan Monnier wrote:
> That was a misunderstanding: the discussion has never been about
> emacs-24 AFAICT since it's not about fixing a bug.
May be I just misunderstood the development/release process as a whole,
but what "it's too late" means for the trunk?
> We don't have the behavior for aref, but we do have it for nth and
> gethash and people frequently rely on this behavior.
Hm...lists are mutable - you can concatenate A and B (with setcdr)
and get changed A but not the copy of A + B. On the other side, I always
consider strings and vectors as "less mutable", which implies more strict
checking (as with aref and aset).
> Now that it's installed, I guess we can try to run with it for a while,
> but I expect we'll get many bug reports from it because external
> packages rely on that behavior (just like bundled packages relied on it,
> or even more so since many external packages don't use string-prefix-p
> because it didn't exist back then).
In ELPA, I don't see too much users of compare-strings:
$ grep -nHR "(compare-strings " .
packages/company/company.el:1093: (not (eq t (compare-strings (car candidates) nil nil
packages/vlf/vlf-ediff.el:323: (eq t (compare-strings suffix nil nil string start-pos nil
packages/gnugo/gnugo.el:290: (compare-strings s1 beg1 nil s2 beg2 nil))
I can check other external packages as well. Emacspeak?
Dmitry
next prev parent reply other threads:[~2014-06-25 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WzkZx-0001rH-5h@vcs.savannah.gnu.org>
2014-06-25 13:22 ` trunk r117396: Do not allow out-of-range character position in Fcompare_strings Dmitry
2014-06-25 13:46 ` Dmitry Antipov
2014-06-25 15:17 ` Stefan Monnier
2014-06-25 15:57 ` Dmitry Antipov [this message]
2014-06-25 16:19 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AAF174.40002@yandex.ru \
--to=dmantipov@yandex.ru \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).