unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Antipov <dmantipov@yandex.ru>
To: Dmitry <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r117396: Do not allow out-of-range character position in Fcompare_strings.
Date: Wed, 25 Jun 2014 17:46:14 +0400	[thread overview]
Message-ID: <53AAD2A6.5060705@yandex.ru> (raw)
In-Reply-To: <86wqc5kttw.fsf@yandex.ru>

On 06/25/2014 05:22 PM, Dmitry wrote:
> IIUC, this small discussion ended with "it's too late to fix".  Why did
> you make the change, then?

"Too late" for emacs-24, which is in pretest stage.

> And if it's okay to change the semantics, why not change it the other
> way, relaxing `substring' requirements?

Why relaxing? IMO relaxing just means more error-prone code (imagine
an `aset' which silently ignores writing an element beyond array end,
or `aref' which always returns nil in that case).

Anyway, you can defsubst a tiny wrapper to relax if you need.

Dmitry




  reply	other threads:[~2014-06-25 13:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1WzkZx-0001rH-5h@vcs.savannah.gnu.org>
2014-06-25 13:22 ` trunk r117396: Do not allow out-of-range character position in Fcompare_strings Dmitry
2014-06-25 13:46   ` Dmitry Antipov [this message]
2014-06-25 15:17     ` Stefan Monnier
2014-06-25 15:57       ` Dmitry Antipov
2014-06-25 16:19         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AAD2A6.5060705@yandex.ru \
    --to=dmantipov@yandex.ru \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).