From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r117286: Fix last commit. Date: Sun, 08 Jun 2014 11:30:46 -0700 Organization: UCLA Computer Science Department Message-ID: <5394ABD6.1040100@cs.ucla.edu> References: <83mwdn31yg.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1402252294 3581 80.91.229.3 (8 Jun 2014 18:31:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Jun 2014 18:31:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 08 20:31:27 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WthsN-00035x-Kf for ged-emacs-devel@m.gmane.org; Sun, 08 Jun 2014 20:31:27 +0200 Original-Received: from localhost ([::1]:57588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WthsN-0005MI-4K for ged-emacs-devel@m.gmane.org; Sun, 08 Jun 2014 14:31:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WthsC-0005M3-QS for emacs-devel@gnu.org; Sun, 08 Jun 2014 14:31:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wths5-0003KT-Bg for emacs-devel@gnu.org; Sun, 08 Jun 2014 14:31:16 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:38247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wthrv-0003Iv-WF; Sun, 08 Jun 2014 14:31:00 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 31AEA39E8013; Sun, 8 Jun 2014 11:30:59 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Eszdo8rQv1cD; Sun, 8 Jun 2014 11:30:50 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 9980139E8011; Sun, 8 Jun 2014 11:30:50 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 In-Reply-To: <83mwdn31yg.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172413 Archived-At: Eli Zaretskii wrote: >> I wish people could refrain from playing around with the >> >static/extern declarations. > I didn't. I just fixed something that was already there. I think Stefan was referring to the practice of marking symbols as static if they're not used in other modules. Generally speaking this is good practice, as non-expert readers of the code needn't consider whether a static symbol might be used by another module. It can help GCC in the same way. However, I take Stefan's point that the practice gets messy when dealing with functions that can be static on typical GNU/Linux builds but must be extern on other ports. So I installed trunk bzr 117290 to make these symbols extern. This gets rid of the mess, and I hope Stefan considers it simplification and not "playing around".