From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117286: Fix last commit.
Date: Sun, 08 Jun 2014 11:30:46 -0700 [thread overview]
Message-ID: <5394ABD6.1040100@cs.ucla.edu> (raw)
In-Reply-To: <83mwdn31yg.fsf@gnu.org>
Eli Zaretskii wrote:
>> I wish people could refrain from playing around with the
>> >static/extern declarations.
> I didn't. I just fixed something that was already there.
I think Stefan was referring to the practice of marking symbols as
static if they're not used in other modules. Generally speaking this is
good practice, as non-expert readers of the code needn't consider
whether a static symbol might be used by another module. It can help
GCC in the same way.
However, I take Stefan's point that the practice gets messy when dealing
with functions that can be static on typical GNU/Linux builds but must
be extern on other ports. So I installed trunk bzr 117290 to make these
symbols extern. This gets rid of the mess, and I hope Stefan considers
it simplification and not "playing around".
next prev parent reply other threads:[~2014-06-08 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WtB1v-0003W1-TA@vcs.savannah.gnu.org>
2014-06-08 0:50 ` [Emacs-diffs] trunk r117286: Fix last commit Stefan Monnier
2014-06-08 14:33 ` Eli Zaretskii
2014-06-08 18:30 ` Paul Eggert [this message]
2014-06-08 19:14 ` Eli Zaretskii
2014-06-09 16:19 ` Stefan Monnier
2014-06-09 16:44 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5394ABD6.1040100@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).