unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mike Kupfer <kupfer@rawbw.com>
To: Andreas Schwab <schwab@suse.de>
Cc: emacs-devel@gnu.org
Subject: Re: can shr-start go away?
Date: Tue, 12 Nov 2024 07:30:04 -0800	[thread overview]
Message-ID: <5386.1731425404@alto.camomileplus.org> (raw)
In-Reply-To: <mvm34jwyh7b.fsf@suse.de>

Andreas Schwab wrote:

> On Nov 11 2024, Mike Kupfer wrote:
> 
> > shr-tag-img can set shr-start, but it doesn't use shr-start itself.
> 
> shr-tag-img sets it for shr-tag-a.

That might have been the intent at one time.  But shr-tag-a has

  (let ((url (dom-attr dom 'href))
        (title (dom-attr dom 'title))
	(start (point))
	shr-start)

Doesn't that create a new binding for shr-start, which means that
shr-tag-a will not see whatever shr-tag-img did?  (Apologies if this
seems like a dumb question.  Like I wrote, I'm still something of a Lisp
newbie.)

The code has been like this for several releases.  It even precedes the
conversion of shr.el to lexical binding.

Maybe I should ask about this on ding?

mike



  reply	other threads:[~2024-11-12 15:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12  1:59 can shr-start go away? Mike Kupfer
2024-11-12  8:44 ` Andreas Schwab
2024-11-12 15:30   ` Mike Kupfer [this message]
2024-11-12 16:00     ` Andreas Schwab
2024-11-12 16:45       ` Mike Kupfer
2024-11-12 16:53         ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5386.1731425404@alto.camomileplus.org \
    --to=kupfer@rawbw.com \
    --cc=emacs-devel@gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).