From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Thu, 22 Jul 2021 09:47:45 -0400 Message-ID: <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> References: <83h7gw6pyj.fsf@gnu.org> <45EBF16A-C953-42C7-97D1-3A2BFEF7DD01@gmail.com> <83y2a764oy.fsf@gnu.org> <83v95b60fn.fsf@gnu.org> <00DD5BFE-D14E-449A-9319-E7B725DEBFB3@gmail.com> <83r1fz5xr9.fsf@gnu.org> <1AAB1BCC-362B-4249-B785-4E0530E15C60@gmail.com> <83czri67h0.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_B4846814-133E-4EA6-8752-4ABE6D65BB3F" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14294"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?Q?Cl=C3=A9ment_Pit-Claudel?= , Stefan Monnier , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 22 15:49:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6Z4t-0003YG-Ct for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Jul 2021 15:49:31 +0200 Original-Received: from localhost ([::1]:60992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Z4s-0002Rn-Df for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Jul 2021 09:49:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6Z3H-0000zu-NC for emacs-devel@gnu.org; Thu, 22 Jul 2021 09:47:52 -0400 Original-Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]:46675) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6Z3F-0005Ym-N2; Thu, 22 Jul 2021 09:47:51 -0400 Original-Received: by mail-qk1-x72d.google.com with SMTP id k4so5362237qkj.13; Thu, 22 Jul 2021 06:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=vD122OHEtbVsFexLWsz+tdKZYgcs7kLWBU/l1UCC0Kc=; b=IQluNQImRsjfT0fJCSP75ezyRi10tVhFuA3plLhykW1YCjeIcDoOJpWGtMolG7qoIV u7s73rA6Zd4f+BjDg5sZxFH8tmiBK2knDNZHZcH9cPY7+5QEfYOzlBlO3xG3dAD3VC9f vrIax7h2hJM2C/TazW6tJFalPOLWab96MxqRnX541VkjbgBMsgTtx59CPpBQ009OwyRh u7JYlQDQKUyQU9mLQ9H5z1Mzp3BL+20rGloI/13ft2ErbHm7PWwqQKOycMbWk5My3MMk xf5Emv7KuP1PWfFVTEGI39ZCSfb6zeUJKJ/d9/e3jrBwPRJU2SYK9ZoS6ccvD8Lb7Mx9 DyWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=vD122OHEtbVsFexLWsz+tdKZYgcs7kLWBU/l1UCC0Kc=; b=byz2CubCCDMvhvi6ESJepb7PnQI1RwMn7yDnR1LxXsCv/IAQtQzfek3LAABRepzYD0 T++ECLf8SPvmpyalqwzb2PyXMbNstSuRmfV00C6Yi7S/oOnrbXTuHsKYq9fg9xEs4tCK G9k8J1Ssug/9yjPik6zfC7RZfVEk31aagDS+RPK501OOBW9rl5HyspnNn6BqSCYcQkLV Ye1pWhYNNfBULWMxN06rZ5souzfs3Vlc2bKhTDRkgcS14wH4QSRMYFyZPbtsq6Yzip/N TBp60Q4MTvE7Xo1MxiJXkiDggOlU/nErPLMzpwSE6PvPACwqxpqyOI49WBksU8sWnCFt ftOw== X-Gm-Message-State: AOAM530UeSrgq32FE2DKPnGfc1FEn06sU/XrXAwaLQAS8VDAD1oB/da6 bINU38n/pmDE3KLzMcpVzg80qelPC7tkDw== X-Google-Smtp-Source: ABdhPJyU/YSamWzGqz33/YdDo2UwnkK6k8meBuqn2cNrBJbarSGJAgXK2bZVphN0ufG3rkf5/RvM5Q== X-Received: by 2002:a37:684f:: with SMTP id d76mr30446616qkc.357.1626961668297; Thu, 22 Jul 2021 06:47:48 -0700 (PDT) Original-Received: from 2603-7080-0302-635e-501b-d938-5abe-a221.res6.spectrum.com (2603-7080-0302-635e-501b-d938-5abe-a221.res6.spectrum.com. [2603:7080:302:635e:501b:d938:5abe:a221]) by smtp.gmail.com with ESMTPSA id l12sm3318567qtx.45.2021.07.22.06.47.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jul 2021 06:47:47 -0700 (PDT) In-Reply-To: <8335s64v10.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) Received-SPF: pass client-ip=2607:f8b0:4864:20::72d; envelope-from=casouri@gmail.com; helo=mail-qk1-x72d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271464 Archived-At: --Apple-Mail=_B4846814-133E-4EA6-8752-4ABE6D65BB3F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 >=20 >> + // TODO BUF_ZV_BYTE? >=20 > Do you want to discuss this? I'd prefer to have it the other way > around: use BUF_ZV_BYTE by default. The callers could widen the > buffer if they needed to access outside of the narrowing. Yes, I meant to discuss this. The problem with respecting narrowing is = that, a user can freely narrow and widen arbitrarily, and Emacs needs to = translate them into insertion & deletion of the buffer text for = tree-sitter, every time a user narrows or widens the buffer. Plus, if = tree-sitter respects narrowing, it could happen where a user narrows the = buffer, the font-locking changes and is not correct anymore. Maybe = that=E2=80=99s not the user want. Also, if someone narrows and widens = often, maybe narrow to a function for better focus, tree-sitter needs to = constantly re-parse most of the buffer. These are not significant = disadvantages, but what do we get from respecting narrowing that = justifies code complexity and these small annoyances? >> *bytes_read =3D (uint32_t) len; >=20 > Is using uint32_t the restriction of tree-sitter? Doesn't it support > reading more than 2 gigabytes? I=E2=80=99m not sure why it asks for uint32 specifically, but that=E2=80=99= s what it asks for its api. I don=E2=80=99t think you are supposed to = use tree-sitter on files of size of gigabytes, because the author = mentioned that tree-sitter uses over 10x as much memory as the size of = the source file [1]. On files larger than a couple of megabytes, I think = we better turn off tree-sitter. Normally those files are not regular = source files, anyway, and we don=E2=80=99t need a parse tree for a log. That leads to another point. I suspect the memory limit will come before = the speed limit, i.e., as the file size increases, the memory = consumption will become unacceptable before the speed does. So it is = possible that we want to outright disable tree-sitter for larger files, = then we don=E2=80=99t need to do much to improve the responsiveness of = tree-sitter on large files. And we might want to delete the parse tree = if a buffer has been idle for a while. Of course, that=E2=80=99s just my = superstition, we=E2=80=99ll see once we can measure the performance. >=20 >> +DEFUN ("tree-sitter-node-type", >> + Ftree_sitter_node_type, Stree_sitter_node_type, 1, 1, 0, >> + doc: /* Return the NODE's type as a symbol. */) >> + (Lisp_Object node) >> +{ >> + CHECK_TS_NODE (node); >> + TSNode ts_node =3D XTS_NODE (node)->node; >> + const char *type =3D ts_node_type(ts_node); >> + return intern_c_string (type); >=20 > Why do we need to intern the string each time? can't we store the > interned symbol there, instead of a C string, in the first place? I=E2=80=99m not sure what do you mean by =E2=80=9Cstore the interned = symbol there=E2=80=9D, where do I store the interned symbol? (BTW, If = you see something wrong, that=E2=80=99s probably because I don=E2=80=99t = know the right way to do it, and grepping only got me that far.) [1]: = https://github.com/tree-sitter/tree-sitter/issues/222#issuecomment-4359874= 41 = Thanks, Yuan --Apple-Mail=_B4846814-133E-4EA6-8752-4ABE6D65BB3F Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

+ =  // TODO BUF_ZV_BYTE?

Do = you want to discuss this?  I'd prefer to have it the other way
around: use BUF_ZV_BYTE by default.  The callers could = widen the
buffer if they needed to access outside of the = narrowing.

Yes, I meant to discuss this. The problem with = respecting narrowing is that, a user can freely narrow and widen = arbitrarily, and Emacs needs to translate them into insertion & = deletion of the buffer text for tree-sitter, every time a user narrows = or widens the buffer. Plus, if tree-sitter respects narrowing, it could = happen where a user narrows the buffer, the font-locking changes and is = not correct anymore. Maybe that=E2=80=99s not the user want. Also, if = someone narrows and widens often, maybe narrow to a function for better = focus, tree-sitter needs to constantly re-parse most of the buffer. = These are not significant disadvantages, but what do we get from = respecting narrowing that justifies code complexity and these small = annoyances?

  *bytes_read =3D (uint32_t) len;

Is using uint32_t the restriction = of tree-sitter?  Doesn't it support
reading more than = 2 gigabytes?

I=E2=80=99m not sure why it asks for uint32 = specifically, but that=E2=80=99s what it asks for its api. I don=E2=80=99t= think you are supposed to use tree-sitter on files of size of = gigabytes, because the author mentioned that tree-sitter uses over 10x as much = memory as the size of the source file [1]. On files larger = than a couple of megabytes, I think we better turn off tree-sitter. = Normally those files are not regular source files, anyway, and we = don=E2=80=99t need a parse tree for a log.

That leads to another point. I suspect the memory = limit will come before the speed limit, i.e., as the file size = increases, the memory consumption will become unacceptable before the = speed does. So it is possible that we want to outright disable = tree-sitter for larger files, then we don=E2=80=99t need to do much to = improve the responsiveness of tree-sitter on large files. And we might = want to delete the parse tree if a buffer has been idle for a while. Of = course, that=E2=80=99s just my superstition, we=E2=80=99ll see once we = can measure the performance.


+DEFUN = ("tree-sitter-node-type",
+ =       Ftree_sitter_node_type, = Stree_sitter_node_type, 1, 1, 0,
+ =       doc: /* Return the NODE's type as a = symbol.  */)
+  (Lisp_Object node)
+{
+  CHECK_TS_NODE (node);
+ =  TSNode ts_node =3D XTS_NODE (node)->node;
+ =  const char *type =3D ts_node_type(ts_node);
+ =  return intern_c_string (type);

Why do we need to intern the string each time? can't we store = the
interned symbol there, instead of a C string, in the = first place?

I=E2=80=99m not sure what do you mean by =E2=80=9Cst= ore the interned symbol there=E2=80=9D, where do I store the interned = symbol? (BTW, If you see something wrong, that=E2=80=99s probably = because I don=E2=80=99t know the right way to do it, and grepping only = got me that far.)


Thanks,
Yuan

= --Apple-Mail=_B4846814-133E-4EA6-8752-4ABE6D65BB3F--