unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] emacs-24 r117077: Fix initialization of minibuffer history variable, bug #17430.
       [not found] <E1Wi3PB-0001JS-T1@vcs.savannah.gnu.org>
@ 2014-05-07 18:30 ` Stefan Monnier
  2014-05-07 19:37   ` Paul Eggert
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2014-05-07 18:30 UTC (permalink / raw)
  To: Jarek Czekalski; +Cc: emacs-devel

>    if (!NILP (Vminibuffer_completing_file_name))
>      Vminibuffer_completing_file_name = Qlambda;
 
> +  /* If variable is unbound, make it nil.  */
> +  Lisp_Object histval = find_symbol_value (Vminibuffer_history_variable);

Emacs currently presumes a C version that doesn't allow such
"declarations after statements".


        Stefan



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Emacs-diffs] emacs-24 r117077: Fix initialization of minibuffer history variable, bug #17430.
  2014-05-07 18:30 ` [Emacs-diffs] emacs-24 r117077: Fix initialization of minibuffer history variable, bug #17430 Stefan Monnier
@ 2014-05-07 19:37   ` Paul Eggert
  2014-05-07 20:05     ` Jarek Czekalski
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggert @ 2014-05-07 19:37 UTC (permalink / raw)
  To: Stefan Monnier, Jarek Czekalski; +Cc: 17430, Emacs development discussions

On 05/07/2014 11:30 AM, Stefan Monnier wrote:
> Emacs currently presumes a C version that doesn't allow such 
> "declarations after statements".

Thanks, fixed in emacs-24 bzr 117079.  Indenting fixed too.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Emacs-diffs] emacs-24 r117077: Fix initialization of minibuffer history variable, bug #17430.
  2014-05-07 19:37   ` Paul Eggert
@ 2014-05-07 20:05     ` Jarek Czekalski
  0 siblings, 0 replies; 3+ messages in thread
From: Jarek Czekalski @ 2014-05-07 20:05 UTC (permalink / raw)
  To: Paul Eggert, Stefan Monnier; +Cc: Emacs development discussions

W dniu 05/07/2014 09:37 PM, Paul Eggert pisze:
> On 05/07/2014 11:30 AM, Stefan Monnier wrote:
>> Emacs currently presumes a C version that doesn't allow such 
>> "declarations after statements".
>
> Thanks, fixed in emacs-24 bzr 117079.  Indenting fixed too.
>

Thank you guys. I intended to correct these things and already started 
branchin emacs24 on my evening machine, but you were faster. And thanks 
for the prompt review, Stefan.

Jarek




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-07 20:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1Wi3PB-0001JS-T1@vcs.savannah.gnu.org>
2014-05-07 18:30 ` [Emacs-diffs] emacs-24 r117077: Fix initialization of minibuffer history variable, bug #17430 Stefan Monnier
2014-05-07 19:37   ` Paul Eggert
2014-05-07 20:05     ` Jarek Czekalski

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).