From: Jarek Czekalski <jarek@jarek.katowice.pl>
To: emacs-devel@gnu.org
Subject: Re: Trunk r117046 fails on systems with older automake
Date: Wed, 07 May 2014 08:36:35 +0200 [thread overview]
Message-ID: <5369D473.6050408@jarek.katowice.pl> (raw)
In-Reply-To: <jalhue1wfw.fsf@fencepost.gnu.org>
W dniu 2014-05-06 22:30, Glenn Morris pisze:
> Andy Moreton wrote:
>
>> dnl automake 1.13 and later understand this, making -I m4 unnecessary.
>> AC_CONFIG_MACRO_DIR(m4)
>>
>> >From that comment I assumed that you had changed the required minimum
>> version without documenting it.
> Well, that was an incorrect assumption.
>
>
Glenn,
r117046 is an example of worst possible commit message. The commit
message should explain the reason for which the change was done. Most of
us don't know why the change was needed. Now we now how much fuss an
unclear commit may do.
Jarek
next prev parent reply other threads:[~2014-05-07 6:36 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 12:01 Trunk r117046 fails on systems with older automake Andy Moreton
2014-05-04 16:17 ` Eli Zaretskii
2014-05-04 18:02 ` Glenn Morris
2014-05-04 18:15 ` Eli Zaretskii
2014-05-04 23:01 ` Glenn Morris
2014-05-05 6:10 ` Eli Zaretskii
2014-05-05 7:00 ` Paul Eggert
2014-05-04 19:28 ` Juanma Barranquero
2014-05-04 19:39 ` Andreas Schwab
2014-05-04 19:51 ` Juanma Barranquero
2014-05-04 20:28 ` Paul Eggert
2014-05-05 6:04 ` Eli Zaretskii
2014-05-04 21:15 ` Andreas Schwab
2014-05-05 19:08 ` Andy Moreton
2014-05-06 19:47 ` Glenn Morris
2014-05-06 23:53 ` Andy Moreton
2014-05-07 0:04 ` Glenn Morris
2014-05-07 2:00 ` Stephen J. Turnbull
2014-05-07 2:14 ` Paul Eggert
2014-05-07 2:58 ` Eli Zaretskii
2014-05-07 4:00 ` Paul Eggert
2014-05-07 15:03 ` Eli Zaretskii
2014-05-08 0:05 ` Andy Moreton
2014-05-08 2:47 ` Eli Zaretskii
2014-05-08 8:00 ` Andy Moreton
2014-05-08 15:05 ` Eli Zaretskii
2014-05-08 15:14 ` Andy Moreton
2014-05-08 15:44 ` Eli Zaretskii
2014-05-07 9:42 ` Andy Moreton
2014-05-07 10:13 ` martin rudalics
2014-05-07 15:17 ` Eli Zaretskii
2014-05-07 15:45 ` martin rudalics
2014-05-07 15:58 ` Eli Zaretskii
2014-05-07 15:14 ` Eli Zaretskii
2014-05-07 2:57 ` Eli Zaretskii
2014-05-07 4:48 ` Stephen J. Turnbull
2014-05-07 15:05 ` Eli Zaretskii
2014-05-07 19:40 ` Stephen J. Turnbull
2014-05-08 2:54 ` Eli Zaretskii
2014-05-07 6:41 ` Glenn Morris
2014-05-07 7:38 ` David Kastrup
2014-05-07 1:03 ` Óscar Fuentes
2014-05-07 2:55 ` Eli Zaretskii
2014-05-07 11:33 ` Óscar Fuentes
2014-05-07 15:18 ` Eli Zaretskii
2014-05-07 15:38 ` Óscar Fuentes
2014-05-07 15:55 ` Eli Zaretskii
2014-05-07 16:06 ` Óscar Fuentes
2014-05-07 2:53 ` Eli Zaretskii
2014-05-07 14:51 ` Juanma Barranquero
2014-05-07 15:32 ` Eli Zaretskii
2014-05-07 17:18 ` Juanma Barranquero
2014-05-07 18:10 ` Eli Zaretskii
2014-05-08 0:25 ` Andy Moreton
2014-05-05 6:01 ` Eli Zaretskii
2014-05-05 5:54 ` Eli Zaretskii
2014-05-05 7:29 ` martin rudalics
2014-05-05 9:03 ` Eli Zaretskii
2014-05-05 9:25 ` martin rudalics
2014-05-05 9:58 ` Eli Zaretskii
2014-05-05 12:29 ` martin rudalics
2014-05-05 13:15 ` Eli Zaretskii
2014-05-05 13:26 ` martin rudalics
2014-05-05 13:50 ` Eli Zaretskii
2014-05-05 6:13 ` Eli Zaretskii
2014-05-04 17:55 ` Glenn Morris
2014-05-05 22:17 ` Andy Moreton
2014-05-06 20:30 ` Glenn Morris
2014-05-07 6:36 ` Jarek Czekalski [this message]
2014-05-07 6:42 ` Glenn Morris
2014-05-07 6:52 ` Jarek Czekalski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5369D473.6050408@jarek.katowice.pl \
--to=jarek@jarek.katowice.pl \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).