From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Patch for build failure on OS X (under review) Date: Tue, 06 May 2014 14:16:32 -0700 Organization: UCLA Computer Science Department Message-ID: <53695130.2020703@cs.ucla.edu> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1399413585 21247 80.91.229.3 (6 May 2014 21:59:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 May 2014 21:59:45 +0000 (UTC) Cc: Emacs devel To: Alp Aker , Andrew Schwartzmeyer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 06 23:59:38 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WhnOi-00015O-2m for ged-emacs-devel@m.gmane.org; Tue, 06 May 2014 23:59:36 +0200 Original-Received: from localhost ([::1]:37370 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whmja-0005MN-HY for ged-emacs-devel@m.gmane.org; Tue, 06 May 2014 17:17:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhmjQ-0005LB-FY for emacs-devel@gnu.org; Tue, 06 May 2014 17:17:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhmjI-0004N0-Tt for emacs-devel@gnu.org; Tue, 06 May 2014 17:16:56 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:49770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhmjI-0004Kz-OV for emacs-devel@gnu.org; Tue, 06 May 2014 17:16:48 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id CC00EA6001C; Tue, 6 May 2014 14:16:40 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cRmuGuygFMHW; Tue, 6 May 2014 14:16:33 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 0A02E39E801D; Tue, 6 May 2014 14:16:33 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171696 Archived-At: On 05/06/2014 01:10 PM, Alp Aker wrote: > The code that's causing the error shouldn't be compiled at all on an > NS build; it's in a large block that's conditioned on HAVE_PNG, which > the NS build expects to be false, as that port supplies its on version > of png_load(). Ah, sorry, I didn't know HAVE_NS and HAVE_PNG were supposed to be mutually exclusive. In trunk bzr 117068 I installed a patch that I hope fixes things, though I don't have easy access to OS X and have not tested it there. Please give it a try.