From: Paul Eggert <eggert@cs.ucla.edu>
To: Alp Aker <alptekin.aker@gmail.com>,
Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
Cc: Emacs devel <emacs-devel@gnu.org>
Subject: Re: Patch for build failure on OS X (under review)
Date: Tue, 06 May 2014 14:16:32 -0700 [thread overview]
Message-ID: <53695130.2020703@cs.ucla.edu> (raw)
In-Reply-To: <CACxch4r1hUohRqGUcvxHdyQS2--OzGYcLhON+ZU+Q9SG15xEPQ@mail.gmail.com>
On 05/06/2014 01:10 PM, Alp Aker wrote:
> The code that's causing the error shouldn't be compiled at all on an
> NS build; it's in a large block that's conditioned on HAVE_PNG, which
> the NS build expects to be false, as that port supplies its on version
> of png_load().
Ah, sorry, I didn't know HAVE_NS and HAVE_PNG were supposed to be
mutually exclusive. In trunk bzr 117068 I installed a patch that I hope
fixes things, though I don't have easy access to OS X and have not
tested it there. Please give it a try.
next prev parent reply other threads:[~2014-05-06 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 2:39 Patch for build failure on OS X (under review) Andrew Schwartzmeyer
2014-05-06 20:06 ` Alp Aker
2014-05-06 20:10 ` Alp Aker
2014-05-06 21:16 ` Paul Eggert [this message]
2014-05-07 7:14 ` Harald Hanche-Olsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53695130.2020703@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=alptekin.aker@gmail.com \
--cc=andrew@schwartzmeyer.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).