From: "Jan D." <jan.h.d@swipnet.se>
Cc: hunterd42@comcast.net, Eli Zaretskii <eliz@gnu.org>,
jasonr@gnu.org, kobayays@otsukakj.co.jp, emacs-devel@gnu.org
Subject: Re: Hourglass only for X-windows?
Date: Fri, 11 Mar 2005 18:25:26 +0100 [thread overview]
Message-ID: <534dd629871884654f6c43846c34db9a@swipnet.se> (raw)
In-Reply-To: <00ee01c52659$a01c9620$0200a8c0@sedrcw11488>
>> This would require to have some configury stuff that would detect
>> whether HAVE_HOURGLASS should be defined or not. Since Windows
>> doesn't run the usual configure script (and neither does the DOS
>> port), adding such a define will require more hacking in these ports.
>> Especially since writing a test for this feature is not so easy even
>> for those platforms which do support hourglass (e.g., think about
>> Emacs configured with --without-x).
>>
>> So please don't do that. Please replace
>>
>> #ifdef HAVE_X_WINDOWS
>>
>> with
>>
>> #if defined(HAVE_X_WINDOWS) || defined(HAVE_NTGUI)
>
> There is a lot of them. I understand your concern. However we do not
> have to
> do anything difficult to use HAVE_HOURGLASS. After taking a look at
> the code
> I believe HAVE_HOURGLASS should go into src\config.in. There is
> already an
> #ifdef HAVE_X_WINDOWS and I suggest putting something like this after
> that
> define:
>
> /* This is for the hourglass code in various files. */
> #if defined(HAVE_X_WINDOWS) || defined(HAVE_NTGUI)
> #define HAVE_HOURGLASS
> #endif
>
> IMO it will be more readable and if you want to add hourglass code for
> other
> systems some day it is easier.
But the w32 port does not expand config.in to config.h AFAIK, so this
does nothing when building on w32.
Jan D.
next prev parent reply other threads:[~2005-03-11 17:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-27 17:57 Hourglass only for X-windows? Lennart Borgman
2005-02-27 20:29 ` Eli Zaretskii
2005-02-28 0:20 ` Lennart Borgman
2005-02-28 4:38 ` Eli Zaretskii
2005-02-28 15:57 ` Lennart Borgman
2005-02-28 23:05 ` Eli Zaretskii
2005-03-01 0:17 ` Lennart Borgman
2005-03-10 23:33 ` Lennart Borgman
2005-03-11 13:28 ` Eli Zaretskii
2005-03-11 13:44 ` Jason Rumney
2005-03-11 15:51 ` Eli Zaretskii
2005-03-11 16:03 ` Lennart Borgman
2005-03-11 16:15 ` Eli Zaretskii
2005-03-11 16:43 ` Lennart Borgman
2005-03-11 17:25 ` Jan D. [this message]
2005-03-11 18:42 ` Lennart Borgman
2005-03-11 20:51 ` Eli Zaretskii
2005-03-12 1:03 ` Lennart Borgman
2005-03-12 2:11 ` Jason Rumney
2005-03-12 9:37 ` Lennart Borgman
2005-03-12 11:43 ` Jan D.
2005-03-12 13:41 ` Stefan Monnier
2005-03-12 15:41 ` Jason Rumney
2005-03-13 3:50 ` David Hunter
2005-03-14 11:28 ` YAMAMOTO Mitsuharu
2005-03-13 15:29 ` Richard Stallman
2005-03-12 10:01 ` Eli Zaretskii
2005-03-12 21:40 ` Lennart Borgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534dd629871884654f6c43846c34db9a@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=hunterd42@comcast.net \
--cc=jasonr@gnu.org \
--cc=kobayays@otsukakj.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).