Wrong scroll bar in cygw32 build of emacs-24?

Wrong scroll bar in cygw32 build of emacs-24?

[Angelo Graziosi]

The cygw32 (--with-w32, Cygwin64) build on Windows 7 of emacs-24 shows a 
scroll bar which looks as on XP instead as on Win7. The same build for 
emacs-trunk looks fine.

I wonder if this is a bug or if it should still back-ported to the 
emacs-24 branch..


Ciao,
  Angelo.

Re: Wrong scroll bar in cygw32 build of emacs-24?

[Eli Zaretskii]

> Date: Tue, 08 Apr 2014 16:09:36 +0200
> From: Angelo Graziosi <angelo.graziosi@alice.it>
> 
> The cygw32 (--with-w32, Cygwin64) build on Windows 7 of emacs-24 shows a 
> scroll bar which looks as on XP instead as on Win7. The same build for 
> emacs-trunk looks fine.
> 
> I wonder if this is a bug or if it should still back-ported to the 
> emacs-24 branch..

Which bzr revisions (or which update dates) did you use on each branch
for building the binaries?

Re: Wrong scroll bar in cygw32 build of emacs-24?

[Eli Zaretskii]

> From: arthur miller <arthur.miller@live.com>
> Date: Tue, 8 Apr 2014 18:00:52 +0200
> 
> > Date: Tue, 8 Apr 2014 18:52:07 +0300
> > From: eliz@gnu.org
> > Subject: Re: Wrong scroll bar in cygw32 build of emacs-24?
> > To: angelo.graziosi@alice.it
> > CC: emacs-devel@gnu.org
> > 
> > > Date: Tue, 08 Apr 2014 16:09:36 +0200
> > > From: Angelo Graziosi <angelo.graziosi@alice.it>
> > > 
> > > The cygw32 (--with-w32, Cygwin64) build on Windows 7 of emacs-24 shows a 
> > > scroll bar which looks as on XP instead as on Win7. The same build for 
> > > emacs-trunk looks fine.
> > > 
> > > I wonder if this is a bug or if it should still back-ported to the 
> > > emacs-24 branch..
> > 
> > Which bzr revisions (or which update dates) did you use on each branch
> > for building the binaries?
> > 
> GNU Emacs 24.4.50.2 (x86_64-w64-mingw32)
>  of 2014-04-06 on KAEL
> Copyright (C) 2014 Free Software Foundation, Inc.
> 
> One from two days ago :).
> 
> http://sourceforge.net/projects/emacsbinw64/?source=directory

This is a different binary, not a cygw32 one.

Re: Wrong scroll bar in cygw32 build of emacs-24?

[Angelo Graziosi]

Il 08/04/2014 17:52, Eli Zaretskii ha scritto:
>> Date: Tue, 08 Apr 2014 16:09:36 +0200
>> From: Angelo Graziosi <angelo.graziosi@alice.it>
>>
>> The cygw32 (--with-w32, Cygwin64) build on Windows 7 of emacs-24 shows a
>> scroll bar which looks as on XP instead as on Win7. The same build for
>> emacs-trunk looks fine.
>>
>> I wonder if this is a bug or if it should still back-ported to the
>> emacs-24 branch..
>
> Which bzr revisions (or which update dates) did you use on each branch
> for building the binaries?
>

Really I have used the git mirror (git://git.savannah.gnu.org/emacs.git)...

I would say the last.. I tried few hours before I sent the message. But 
I noticed this also a few days ago. I don't see big changes in trunk and 
emacs-24 in the last 2-3 days.

Ciao,
Angelo.

Re: Wrong scroll bar in cygw32 build of emacs-24?

[Angelo Graziosi]

Bingo!

Il 08/04/2014 17:52, Eli Zaretskii ha scritto:
>> Date: Tue, 08 Apr 2014 16:09:36 +0200
>> From: Angelo Graziosi <angelo.graziosi@alice.it>
>>
>> The cygw32 (--with-w32, Cygwin64) build on Windows 7 of emacs-24 shows a
>> scroll bar which looks as on XP instead as on Win7. The same build for
>> emacs-trunk looks fine.
>>
>> I wonder if this is a bug or if it should still back-ported to the
>> emacs-24 branch..
>
> Which bzr revisions (or which update dates) did you use on each branch
> for building the binaries?
>

I have just discovered that today trunk (maybe after the merge from 
emacs-24 branch) has the same problem!

For example, this trunk

http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=trunk&id=a2260459f06a0f41f0490b0a1da83d27bd0d933d

has the scroll bar which looks ok on Win7 while the trunk

http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=trunk&id=3a0bc91552456e0ae62ad625e3408762fe88cc15

has already the wrong scroll bar (XP-like) on Win7.

Notice I am speaking of a cygw32 build, which is a Cygwin build with the 
look of Windows.

Instead the Windows native binaries I find here

http://sourceforge.net/projects/emacsbinw64

(today trunk 20140408) have the correct scroll bar.

I would say that the emacs-24 bug has been back - oops - forwarded to 
the trunk...

Ciao,
  Angelo.

Re: Wrong scroll bar in cygw32 build of emacs-24?

[Ken Brown]

On 4/8/2014 5:59 PM, Angelo Graziosi wrote:
> Bingo!
>
> Il 08/04/2014 17:52, Eli Zaretskii ha scritto:
>>> Date: Tue, 08 Apr 2014 16:09:36 +0200
>>> From: Angelo Graziosi <angelo.graziosi@alice.it>
>>>
>>> The cygw32 (--with-w32, Cygwin64) build on Windows 7 of emacs-24 shows a
>>> scroll bar which looks as on XP instead as on Win7. The same build for
>>> emacs-trunk looks fine.
>>>
>>> I wonder if this is a bug or if it should still back-ported to the
>>> emacs-24 branch..
>>
>> Which bzr revisions (or which update dates) did you use on each branch
>> for building the binaries?
>>
>
> I have just discovered that today trunk (maybe after the merge from
> emacs-24 branch) has the same problem!
>
> For example, this trunk
>
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=trunk&id=a2260459f06a0f41f0490b0a1da83d27bd0d933d
>
>
> has the scroll bar which looks ok on Win7 while the trunk
>
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=trunk&id=3a0bc91552456e0ae62ad625e3408762fe88cc15
>
>
> has already the wrong scroll bar (XP-like) on Win7.
>
> Notice I am speaking of a cygw32 build, which is a Cygwin build with the
> look of Windows.
>
> Instead the Windows native binaries I find here
>
> http://sourceforge.net/projects/emacsbinw64
>
> (today trunk 20140408) have the correct scroll bar.
>
> I would say that the emacs-24 bug has been back - oops - forwarded to
> the trunk...

I don't have time to check this right now, but it's a pretty good bet 
that this is a result of my recent change to use the (new) default 
Cygwin manifest instead of the one provided by emacs:

revno: 116901
committer: Ken Brown <kbrown@cornell.edu>
branch nick: emacs-24
timestamp: Thu 2014-04-03 15:10:35 -0400
message:
   Don't use manifest on Cygwin.  (Bug#17176)

   * nt/emacs.rc: Don't use manifest on Cygwin.
   * configure.ac (EMACS_MANIFEST, UPDATE_MANIFEST): Leave these
   variables empty on Cygwin.
   * src/Makefile.in (EMACS_MANIFEST): Update comment.
modified:
   ChangeLog
   configure.ac
   nt/ChangeLog
   nt/emacs.rc
   src/ChangeLog
   src/Makefile.in

A little googling suggests that the difference might be due to the fact 
that the emacs manifest mentions Common Controls version 6, but the one 
provided by Cygwin doesn't.

If my guess is right, then this is a Cygwin/binutils issue rather than 
an emacs issue.

Ken

Re: Wrong scroll bar in cygw32 build of emacs-24?

[Eli Zaretskii]

> Date: Tue, 08 Apr 2014 22:20:58 -0400
> From: Ken Brown <kbrown@cornell.edu>
> Cc: emacs-devel@gnu.org
> 
> I don't have time to check this right now, but it's a pretty good bet 
> that this is a result of my recent change to use the (new) default 
> Cygwin manifest instead of the one provided by emacs:

Yes, that'd be my guess as well.

> A little googling suggests that the difference might be due to the fact 
> that the emacs manifest mentions Common Controls version 6, but the one 
> provided by Cygwin doesn't.
> 
> If my guess is right, then this is a Cygwin/binutils issue rather than 
> an emacs issue.

Indeed, and that's exactly the disadvantage which I alluded to when
you suggested that change: you can no longer fix some problems visible
in Emacs by changes in Emacs itself, you now depend on Binutils
maintainers getting their act together, and fast.

Re: Wrong scroll bar in cygw32 build of emacs-24?

[Ken Brown]

On 4/8/2014 10:46 PM, Eli Zaretskii wrote:
>> Date: Tue, 08 Apr 2014 22:20:58 -0400
>> From: Ken Brown <kbrown@cornell.edu>
>> Cc: emacs-devel@gnu.org
>>
>> I don't have time to check this right now, but it's a pretty good bet
>> that this is a result of my recent change to use the (new) default
>> Cygwin manifest instead of the one provided by emacs:
>
> Yes, that'd be my guess as well.
>
>> A little googling suggests that the difference might be due to the fact
>> that the emacs manifest mentions Common Controls version 6, but the one
>> provided by Cygwin doesn't.
>>
>> If my guess is right, then this is a Cygwin/binutils issue rather than
>> an emacs issue.
>
> Indeed, and that's exactly the disadvantage which I alluded to when
> you suggested that change: you can no longer fix some problems visible
> in Emacs by changes in Emacs itself, you now depend on Binutils
> maintainers getting their act together, and fast.

I might have to rethink this.  First, I'm going to make a bug report 
about the Cygwin/Binutils problem that started all this: The stripped 
executable is messed up when both manifests were used.  I've looked back 
at the discussion when it was decided to add a default manifest on 
Cygwin, and the intention was that this would be ignored if the 
application provided its own manifest.  For some reason that isn't 
working right in this case.

Ken

Re: Wrong scroll bar in cygw32 build of emacs-24?

[Eli Zaretskii]

> Date: Wed, 09 Apr 2014 10:40:57 -0400
> From: Ken Brown <kbrown@cornell.edu>
> CC: angelo.graziosi@alice.it, emacs-devel@gnu.org
> 
> I've looked back at the discussion when it was decided to add a
> default manifest on Cygwin, and the intention was that this would be
> ignored if the application provided its own manifest.  For some
> reason that isn't working right in this case.

Indeed, there should be some way for an application specify its own
manifest instead of the standard one provided by Binutils.  Just
specifying one on the command line is, of course, the most convenient
way.

Re: Wrong scroll bar in cygw32 build of emacs-24?

[Angelo Graziosi]

Ciao,

I have built the trunk of this morning (git 35adb6a) reverting the 
change done by Ken, and now the scroll bar looks correct on Win7...

Il 09/04/2014 17:05, Eli Zaretskii ha scritto:

>> I've looked back at the discussion when it was decided to add a
>> default manifest on Cygwin, and the intention was that this would be
>> ignored if the application provided its own manifest.  For some
>> reason that isn't working right in this case.
>
> Indeed, there should be some way for an application specify its own
> manifest instead of the standard one provided by Binutils.  Just
> specifying one on the command line is, of course, the most convenient
> way.

The recent changes (mainly the default manifest) in Binutils are 
creating a lot of problems. See

https://sourceware.org/bugzilla/show_bug.cgi?id=16792
https://sourceware.org/bugzilla/show_bug.cgi?id=16807

http://cygwin.com/ml/cygwin/2014-04/msg00137.html
http://cygwin.com/ml/cygwin/2014-04/msg00016.html
...


Ciao,
Angelo.

Re: Wrong scroll bar in cygw32 build of emacs-24?

[Ken Brown]

I've reverted most of my "fix" of Bug#17176 (r116930 on the emacs-24 
branch).  The entire problem that led to the bug report was a binutils 
bug (problems merging Windows resources), not an emacs bug.

Ken