From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: spacibba@aol.com, juri@linkov.net, emacs-devel@gnu.org
Subject: Re: Tabs
Date: Thu, 10 Oct 2019 11:15:55 +0200 [thread overview]
Message-ID: <53365bd1-96e0-feb1-362d-1d8b6a35450f@gmx.at> (raw)
In-Reply-To: <83zhi9u57j.fsf@gnu.org>
> Ah, so these are one-off flags, and not indications of the resize,
> i.e. they are not supposed to be sensitive to, say, when a tool bar
> becomes too large for one line and needs two, is that so?
They are one-off in the following sense:
(1) Initially the flags are off. redisplay_tool_bar unconditionally
sets f->tool_bar_redisplayed to true every time it runs, so
redisplay_tool_bar is, by design, agnostic of the underlying
mechanism.
(2) The mechanism for exceptionally allowing to change the frame
height when a tool bar height shall be established is confined to
the change_tool_bar_height functions and their GTK counterpart.
There, f->tool_bar_redisplayed is reset if certain conditions are
met so any earlier calculation by redisplay_tool_bar is forgotten
- don't ask me if such a calculation could have happened in
practice, I don't remember.
In either case the mechanism is only sharpened here and as we have
seen with Bug#37609 its effect may trigger a long time after the
initial frame has been made. Maybe we could inhibit it by having
any caller(s) of redisplay_tool_bar set f->tool_bar_redisplayed
even if they do not call redisplay_tool_bar. But I'm not sure.
ISTR that I tried alternative solutions for this but was always
surprised at how late in the frame creation phase the tool bar
could take on its final, exact size.
(3) Once the frame has been made and f->tool_bar_resized is set, the
latter is never reset again and it's really one-off in the sense
you described.
>> As you mentioned earlier, tab bars are initially off and the tool bar
>> is on. Maybe that's the cause of the problem.
>
> No, I think the cause of the problem is that we have no equivalent of
> "C-x 6 f" that turns on the tool bar as a side effect of a command
> that displays a buffer.
I'm missing you here. Do you mean that displaying a tool bar for the
first time in an Emacs session on a specific frame when you display a
certain buffer on that frame would have a similar dramatic effect?
Couldn't you verify that?
> But that's a guess, because I've just
> established with Jimmy's help that even the call to redraw_frame
> doesn't cause the expected effect. Which completely stumps me, and I
> need to think about it before I come with more ideas (_if_ I come with
> more ideas)...
I'm still not entirely sure whether it was a good idea to cargo cult
the tab bar code from the tool bar code. Not that I have a
substantially better offer. As a matter of fact, we should have
provided a good pseudo window mechanism for that.
martin
next prev parent reply other threads:[~2019-10-10 9:15 UTC|newest]
Thread overview: 211+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 20:45 Tabs Juri Linkov
2019-09-01 8:12 ` Tabs martin rudalics
2019-09-01 14:40 ` Tabs Eli Zaretskii
2019-09-01 19:57 ` Tabs Juri Linkov
2019-09-02 0:40 ` Tabs Stefan Kangas
2019-09-02 10:11 ` Tabs Elias Mårtenson
2019-09-02 11:16 ` Tabs Dmitry Gutov
2019-09-02 19:27 ` Tabs Juri Linkov
2019-09-03 5:21 ` Tabs Jean Louis
2019-09-03 19:40 ` Tabs Juri Linkov
2019-09-03 20:14 ` Tabs Jean Louis
2019-09-02 19:17 ` Tabs Juri Linkov
2019-09-03 5:45 ` Tabs Yuri Khan
2019-09-03 19:45 ` Tabs Juri Linkov
2019-09-15 16:44 ` Tabs Stefan Kangas
2019-09-15 21:17 ` Tabs Juri Linkov
2019-09-02 2:29 ` Tabs Eli Zaretskii
2019-09-02 19:29 ` Tabs Juri Linkov
2019-09-03 2:27 ` Tabs Eli Zaretskii
2019-09-01 8:59 ` Tabs (on macos) Jean-Christophe Helary
2019-09-01 20:11 ` Juri Linkov
2019-09-16 13:41 ` Stefan Kangas
2019-09-16 20:33 ` Juri Linkov
2019-09-17 9:11 ` Stefan Kangas
2019-09-17 9:29 ` Stefan Kangas
2019-09-17 20:28 ` Juri Linkov
2019-09-17 22:38 ` Stefan Kangas
2019-09-20 18:26 ` Alan Third
2019-09-17 23:29 ` Stefan Kangas
2019-09-01 9:28 ` Tabs Alan Mackenzie
2019-09-01 19:18 ` Tabs Juri Linkov
2019-09-01 12:31 ` Tabs Ergus
2019-09-01 19:31 ` Tabs Juri Linkov
2019-09-02 4:51 ` Tabs Ergus
2019-09-02 19:33 ` Tabs Juri Linkov
2019-09-02 21:06 ` Tabs Stefan Monnier
2019-09-03 19:56 ` Tabs Juri Linkov
2019-09-03 2:30 ` Tabs Eli Zaretskii
2019-09-03 19:58 ` Tabs Juri Linkov
2019-09-03 5:39 ` Tabs Ergus
2019-09-05 22:24 ` Tabs Ergus
2019-09-07 20:14 ` Tabs Juri Linkov
2019-09-02 12:41 ` Tabs Stefan Monnier
2019-09-02 19:39 ` Tabs Juri Linkov
2019-09-02 21:03 ` Tabs Stefan Monnier
2019-09-03 12:22 ` Tabs Robert Pluim
2019-09-03 20:21 ` Tabs Juri Linkov
2019-09-15 19:21 ` Tabs Stefan Kangas
2019-09-15 21:32 ` Tabs Juri Linkov
2019-09-16 4:19 ` Tabs Yuri Khan
2019-09-16 20:59 ` Tabs Juri Linkov
2019-09-17 5:29 ` Tabs Yuri Khan
2019-09-17 20:37 ` Tabs Juri Linkov
2019-09-17 22:53 ` Tabs Drew Adams
2019-09-28 17:06 ` Tabs Stefan Kangas
2019-09-28 19:52 ` Tabs Juri Linkov
2019-10-20 22:38 ` Tabs Juri Linkov
2019-11-02 21:40 ` Tabs Juri Linkov
2019-09-19 23:57 ` Tabs Michael Heerdegen
2019-09-21 22:45 ` Tabs Juri Linkov
2019-09-22 0:31 ` Tabs Michael Heerdegen
2019-09-25 20:15 ` Tabs Juri Linkov
2019-10-05 13:57 ` Tabs Michael Heerdegen
2019-10-05 22:12 ` Tabs Juri Linkov
2019-10-06 8:22 ` Tabs Michael Heerdegen
2019-10-06 12:09 ` Tabs Michael Heerdegen
2019-10-06 15:16 ` Tabs Michael Heerdegen
2019-10-06 17:49 ` Tabs Eli Zaretskii
2019-10-06 17:55 ` Tabs Juri Linkov
2019-10-06 18:05 ` Tabs Juri Linkov
2019-10-06 18:58 ` Tabs Eli Zaretskii
2019-10-06 18:59 ` Tabs Eli Zaretskii
2019-10-06 19:08 ` Tabs Michael Heerdegen
2019-10-06 19:11 ` Tabs Juri Linkov
2019-10-06 19:21 ` Tabs Eli Zaretskii
2019-10-06 19:58 ` Tabs Juri Linkov
2019-10-07 16:05 ` Tabs Eli Zaretskii
2019-10-07 16:53 ` Tabs Michael Heerdegen
2019-10-07 17:12 ` Tabs Ergus
2019-10-07 18:24 ` Tabs Eli Zaretskii
2019-10-07 19:28 ` Tabs Ergus
2019-10-08 7:42 ` Tabs Eli Zaretskii
2019-10-08 8:56 ` Tabs Ergus
2019-10-08 9:18 ` Tabs Eli Zaretskii
2019-10-08 13:58 ` Tabs Eli Zaretskii
2019-10-08 16:00 ` Tabs Ergus
2019-10-08 16:18 ` Tabs Eli Zaretskii
2019-10-08 16:40 ` Tabs Ergus
2019-10-08 17:03 ` Tabs Eli Zaretskii
2019-10-08 23:43 ` Tabs Ergus
2019-10-09 8:37 ` Tabs Eli Zaretskii
2019-10-09 10:39 ` Tabs Ergus
2019-10-09 11:35 ` Tabs Eli Zaretskii
2019-10-09 12:05 ` Tabs Ergus
2019-10-09 12:18 ` Tabs Eli Zaretskii
2019-10-09 12:32 ` Tabs Eli Zaretskii
2019-10-09 18:12 ` Tabs martin rudalics
2019-10-09 18:46 ` Tabs Eli Zaretskii
2019-10-10 9:15 ` martin rudalics [this message]
2019-10-10 9:59 ` Tabs Eli Zaretskii
2019-10-10 10:38 ` Tabs martin rudalics
2019-10-10 11:33 ` Tabs Eli Zaretskii
2019-10-10 11:53 ` Tabs Eli Zaretskii
2019-10-10 14:58 ` Tabs martin rudalics
2019-10-09 12:36 ` Tabs Eli Zaretskii
2019-10-09 13:55 ` Tabs Ergus
2019-10-09 14:21 ` Tabs Eli Zaretskii
2019-10-09 15:15 ` Tabs Ergus
2019-10-09 15:35 ` Tabs Eli Zaretskii
2019-10-10 11:52 ` Tabs Eli Zaretskii
2019-10-10 13:12 ` Tabs Ergus
2019-10-10 13:54 ` Tabs Eli Zaretskii
2019-10-10 14:19 ` Tabs Ergus
2019-10-10 15:03 ` Tabs Eli Zaretskii
2019-10-10 15:35 ` Tabs martin rudalics
2019-10-10 15:46 ` Tabs Ergus
2019-10-10 18:14 ` Tabs martin rudalics
2019-10-10 18:26 ` Tabs Eli Zaretskii
2019-10-11 8:18 ` Tabs martin rudalics
2019-10-11 9:16 ` Tabs Eli Zaretskii
2019-10-16 9:16 ` Tabs martin rudalics
2019-10-10 13:29 ` Tabs Ergus
2019-10-10 13:47 ` Tabs Eli Zaretskii
2019-10-10 14:15 ` Tabs Ergus
2019-10-10 14:40 ` Tabs Ergus
2019-10-10 15:11 ` Tabs Eli Zaretskii
2019-10-10 20:54 ` Tabs Juri Linkov
2019-10-11 7:08 ` Tabs Eli Zaretskii
2019-10-13 20:57 ` Tabs Juri Linkov
2019-10-09 22:37 ` Tabs Juri Linkov
2019-10-10 7:51 ` Tabs Eli Zaretskii
2019-10-10 22:35 ` Tabs Juri Linkov
2019-10-11 8:18 ` Tabs martin rudalics
2019-10-12 22:42 ` Tabs Juri Linkov
2019-10-13 8:16 ` Tabs martin rudalics
2019-10-14 18:02 ` Tabs martin rudalics
2019-10-14 18:29 ` Tabs Eli Zaretskii
2019-10-15 9:47 ` Tabs martin rudalics
2019-10-14 19:35 ` Tabs Juri Linkov
2019-10-14 21:17 ` Tabs T.V Raman
2019-10-14 21:53 ` Tabs Phil Sainty
2019-10-14 22:00 ` Tabs Juri Linkov
2019-10-14 22:36 ` Tabs T.V Raman
2019-10-15 20:39 ` Tabs Juri Linkov
2019-10-16 0:14 ` Tabs T.V Raman
2019-10-15 6:12 ` Tabs Eli Zaretskii
2019-10-15 9:47 ` Tabs martin rudalics
2019-10-15 17:45 ` Tabs Juri Linkov
2019-10-16 9:16 ` Tabs martin rudalics
2019-10-14 19:00 ` Tabs Juri Linkov
2019-10-15 9:47 ` Tabs martin rudalics
2019-10-11 9:20 ` Tabs Eli Zaretskii
2019-10-12 22:47 ` Tabs Juri Linkov
2019-10-13 6:51 ` Tabs Eli Zaretskii
2019-10-13 20:48 ` Tabs Juri Linkov
2019-10-13 21:09 ` Tabs Eli Zaretskii
2019-10-13 21:33 ` Tabs Juri Linkov
2019-10-14 8:24 ` Tabs Eli Zaretskii
2019-10-07 17:58 ` Tabs Eli Zaretskii
2019-10-07 19:11 ` Tabs Juri Linkov
2019-10-06 18:38 ` Tabs Michael Heerdegen
2019-10-06 19:03 ` Tabs Eli Zaretskii
2019-10-06 18:56 ` Tabs Eli Zaretskii
2019-10-08 19:15 ` Tabs Michael Heerdegen
2019-10-09 22:48 ` Tabs Juri Linkov
2019-10-10 11:06 ` Tabs Michael Heerdegen
2019-10-10 20:59 ` Tabs Juri Linkov
2019-10-13 9:32 ` Tabs Michael Heerdegen
2019-10-13 20:24 ` Tabs Juri Linkov
2019-10-15 14:42 ` Tabs Michael Heerdegen
2019-10-19 22:51 ` Tabs Juri Linkov
2019-10-25 11:19 ` Tabs Michael Heerdegen
2019-10-26 22:40 ` Tabs Juri Linkov
2019-10-29 19:09 ` Tabs Michael Heerdegen
2019-11-05 23:24 ` Tabs Juri Linkov
2019-11-08 18:45 ` Tabs Michael Heerdegen
2019-11-08 19:56 ` Tabs Michael Heerdegen
2019-11-12 21:31 ` Tabs Juri Linkov
2019-11-13 16:47 ` Tabs Michael Heerdegen
2019-11-13 22:10 ` Tabs Juri Linkov
2019-11-14 9:20 ` Tabs martin rudalics
-- strict thread matches above, loose matches on Subject: below --
2019-09-02 13:31 Tabs Angelo Graziosi
2019-09-02 19:46 ` Tabs Juri Linkov
2019-09-03 8:49 ` Tabs Angelo Graziosi
2019-09-03 19:48 ` Tabs Juri Linkov
2019-09-04 8:22 ` Tabs Angelo Graziosi
2019-09-04 19:05 ` Tabs Juri Linkov
2019-09-04 22:41 ` Tabs Angelo Graziosi
2019-09-05 21:40 ` Tabs Angelo Graziosi
2019-09-06 20:16 ` Tabs Angelo Graziosi
2019-09-07 20:28 ` Tabs Juri Linkov
2019-09-08 20:19 ` Tabs Juri Linkov
2019-09-16 7:56 ` Tabs Angelo Graziosi
2019-09-16 8:45 ` Tabs Angelo Graziosi
2019-09-16 20:43 ` Tabs Juri Linkov
2019-10-13 14:49 ` Tabs Angelo Graziosi
2019-10-13 15:07 ` Tabs Eli Zaretskii
2019-10-13 21:09 ` Tabs Angelo Graziosi
2019-10-14 8:23 ` Tabs Eli Zaretskii
2019-10-15 21:38 ` Tabs Angelo Graziosi
2019-10-16 6:53 ` Tabs Eli Zaretskii
2019-10-13 22:08 ` Tabs Juri Linkov
2019-10-14 6:37 ` Tabs Eli Zaretskii
2019-10-15 7:55 ` Tabs Eli Zaretskii
2019-10-15 19:44 ` Tabs Juri Linkov
2019-10-16 6:23 ` Tabs Eli Zaretskii
2019-10-16 22:17 ` Tabs Juri Linkov
2019-10-17 7:17 ` Tabs Eli Zaretskii
2019-10-13 22:01 ` Tabs Juri Linkov
2019-09-03 9:20 Tabs Angelo Graziosi
[not found] <<87a7bpysm8.fsf@mail.linkov.net>
[not found] ` <<d0768d60-979b-8635-b2b5-474742827552@gmx.at>
[not found] ` <<87o903dc2j.fsf@mail.linkov.net>
[not found] ` <<CADwFkmmgvyMzc_RZwz-AD6=cpUGfxdx5VZAv2eau4T9dAkTKQg@mail.gmail.com>
[not found] ` <<CADtN0WKCHd9fA-tCaGckHFQ59+6ns72NdGrvAdKHss0GLYFZ6g@mail.gmail.com>
[not found] ` <<87tv9ubirx.fsf@mail.linkov.net>
[not found] ` <<courier.000000005D6DF86C.00005323@protected.rcdrun.com>
2019-09-03 15:24 ` Tabs Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53365bd1-96e0-feb1-362d-1d8b6a35450f@gmx.at \
--to=rudalics@gmx.at \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).