From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Angelo Graziosi Newsgroups: gmane.emacs.devel Subject: Re: Scroll bars on macOS builds Date: Thu, 27 Jan 2022 23:10:42 +0100 (CET) Message-ID: <531448434.456398.1643321442866@mail1.libero.it> References: <1555566770.476092.1641148898999@mail1.libero.it> <366682291.727051.1641946326079@mail1.libero.it> <835707023.1539255.1642863979389@mail1.libero.it> <51672596.1588540.1642973503861@mail1.libero.it> <246357929.1612108.1642976592962@mail1.libero.it> <147533788.292331.1643216844580@mail1.libero.it> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18641"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 27 23:11:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDCzZ-0004dB-T1 for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Jan 2022 23:11:45 +0100 Original-Received: from localhost ([::1]:47636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDCzY-0004HI-DS for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Jan 2022 17:11:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDCyd-0003AA-5y for emacs-devel@gnu.org; Thu, 27 Jan 2022 17:10:47 -0500 Original-Received: from smtp-18-i2.italiaonline.it ([213.209.12.18]:33734 helo=libero.it) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDCyb-0007dW-CB for emacs-devel@gnu.org; Thu, 27 Jan 2022 17:10:46 -0500 Original-Received: from oxapps-34-155.iol.local ([10.101.8.201]) by smtp-18.iol.local with ESMTPA id DCyYnLzU8dd5VDCyYn03ky; Thu, 27 Jan 2022 23:10:43 +0100 x-libjamoibt: 1601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libero.it; s=s2021; t=1643321443; bh=ZO52YMtQaz7crkrMI1CZ/hlc4RF1u1MSN4WXClLxDk0=; h=From; b=Ecc75VEjSenfq2VHNTRr8F0KLKC+0S5yj+BAIyL+MSCS+5HEXULllKzMBPZLRSIkB /Ebe84iDn2ImvRxQfSUTZm+qbZ+7WeFHBO4j9kB7affZ7OfCXL87T94frcEbTl+Gja +5Yrq1KKiNQlrvMgoQYZOiWoDn3ONdWvZ3aTLhg0iom9bPruIO1903R/P3lI67NYNi R2EpDYiPeYVgrjNr3jptZXry3FhIvIj9WtWTqs2/ARftmUGwQLfrt7P2HzOlYoGRYP 4e+UzY8raLIFREhXTyyJdrO5QqKwahw4YYzyVw3perqdFNZnTT7QlGkb2sD9AItLdM l71z34h34UKXg== X-CNFS-Analysis: v=2.4 cv=ar13tQVV c=1 sm=1 tr=0 ts=61f31863 cx=a_exe a=QNjRtCB8umDrJAk1R1lGrQ==:117 a=GgUNwaLrHmoA:10 a=IkcTkHD0fZMA:10 a=9W5fi9EQ-JYA:10 a=0yxxPPbCAvFEt0c3X74A:9 a=QEXdDO2ut3YA:10 In-Reply-To: X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.5-Rev34 X-Originating-IP: 87.6.236.22 X-Originating-Client: open-xchange-appsuite x-libjamsun: jZqoOU1frk0VdkUf4/8pfWRLItTz0mqP x-libjamv: AFzW3bWcK7g= X-CMAE-Envelope: MS4xfO58sQnxtYQlIQDB2eYZcKIXLKiBFd9jdMvHDJ7L6QGsELfPhqiMb5T3tB/bmYgPjjo3NtBe7s9s/RLT/oEBidWH96KAvcmqnm84BKy8YP+/N9xwjWJD XzqxLJlnsej8VbQU1vQm0vUr+q5nIWR4licjCST9mrEQWN8GPvdQeXqW/TafAdRhtWcGfWc77XnXyntGJt3Y/E+/tZ0hz/+yh1GdA7ndhFUaYFuTOEqvBOjP Received-SPF: pass client-ip=213.209.12.18; envelope-from=angelo.g0@libero.it; helo=libero.it X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285507 Archived-At: > Il 27/01/2022 20:59 Alan Third ha scritto: > > > On Wed, Jan 26, 2022 at 06:07:24PM +0100, Angelo Graziosi wrote: > > > Il 26/01/2022 00:01 Alan Third ha scritto: > > > > > > > > > Can you try changing line 7198 in nsterm.m from > > > > > > [self setWantsLayer:YES]; > > > > > > to > > > > > > [self setWantsLayer:NO]; > > > > > > ? > > > > Emacs crashes at startup. I have rebuilt Emacs from current master and from master-20220111 with your suggestions but it wont start! > > > > Attached the bug report it want to send to Apple people... > > Actually, can you try this again, but remove the call to flushWindow > in unlockFocus (line 7902)? I've a feeling that's a GNUstep method > that's accidentally crept into the Cocoa code. I have built current master with patch (do you mean it?) below and it works, i.e. scrollbars are visible! --- nsterm.m.orig 2022-01-27 22:26:12.000000000 +0100 +++ nsterm.m 2022-01-27 22:44:59.000000000 +0100 @@ -7195,7 +7195,7 @@ on resize. Unfortunately it also means the frame will not be automatically marked for display, but we can do that ourselves in resizeWithOldSuperviewSize. */ - [self setWantsLayer:YES]; + [self setWantsLayer:NO]; [self setLayerContentsRedrawPolicy: NSViewLayerContentsRedrawOnSetNeedsDisplay]; [self setLayerContentsPlacement:NSViewLayerContentsPlacementTopLeft]; @@ -7899,7 +7899,6 @@ else { [super unlockFocus]; - [super flushWindow]; } #endif }