From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Proposing changes to adjust_frame_size Date: Fri, 7 May 2021 10:03:14 +0200 Message-ID: <52a5361a-451e-7167-edfd-09066dfdcc3e@gmx.at> References: <69a5e928-2998-f776-fa0d-f35e6ab1e65d@gmx.at> <20210505.194756.2198057137743556501.masm@luna.pink.masm11.me> <20210505.230733.1330791046879877132.masm@luna.pink.masm11.me> <87a6p9knr9.fsf@gnu.org> <9712b3f0-c442-61fc-93a6-773ffcde1c2e@gmx.at> <87y2cswam6.fsf@gnu.org> <1b11ac72-6687-f2d4-1d9f-0619d6d2462c@gmx.at> <87v97ww8h4.fsf@gnu.org> <87eaa667-b3cd-0274-669c-3cb4e0076ce0@gmx.at> <87sg30vy7w.fsf@gnu.org> <87pmy3x620.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------2B25A8E4A17D31FDF25314E7" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22308"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 07 10:05:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1levU7-0005da-JB for ged-emacs-devel@m.gmane-mx.org; Fri, 07 May 2021 10:05:19 +0200 Original-Received: from localhost ([::1]:44930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1levU6-00039y-MB for ged-emacs-devel@m.gmane-mx.org; Fri, 07 May 2021 04:05:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1levSG-0002Kc-3p for emacs-devel@gnu.org; Fri, 07 May 2021 04:03:26 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:55765) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1levSE-00030k-34; Fri, 07 May 2021 04:03:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620374596; bh=MUZkHx7bmXsBuvmKqmJ7GdEUKpb3TqFS80YHaDnkgQ0=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=ZwybLm9zgJ2cRmKT8ZWp9Bg5aoNFv7nTvWX80/5UCqSp+/KO8GzKzI43JFM/1b3R3 JmpEbYN/8tTvzDecGObDe2R4Z0BV6eDQaHiAZzaygK1owiOnKeK+j6Nnw4ajO+/YNx GBM3Yh9Pijyuusb03Nj8U5Vo313YPyzEFkDM3kvc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([213.142.96.71]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N33Ib-1lXGZd1kY1-013KoG; Fri, 07 May 2021 10:03:16 +0200 In-Reply-To: <87pmy3x620.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:ih/fvkR0zd8ANFsm9hCJMbtGw5WEAP+LvNjeMx+yz2ryjlayD/c IsEZGtHYxqaHXRAn04j61wT3gsmAdi3fsyIoNYq7UmpX8ASgsbkx6DQMYXtD6PbUf4vokLG TBTiiTgb/ZdgPTaxeZzrbfdJdwVSUqzoFTvcoHp3omIEvU0QRsVGq52BiHwwAzaFYkyCPFn dm6MkVIm73cH68eNK2nTQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:4cI/Dou8Vx4=:pjuZNlh7P+bOiSPhCnt3/W vB9RF1PqMpbTOukXeEveCcDH3P2GrrPJmfyYJ8plg2vd8r0GbuYq5QKbYzT99qZPGCizYR3l3 2dpUmOVZYlpidZfWbJuChz8DVAlf51zZp6fXTXJjFdR9FixjecBCn2XfP9fP3NWhgZmVAENzH y8PI93YaVVvXsModnwLzI0pZdrIpKLHwhnQZ5LjPlTHmxK2z2YpBGFgv09aLz7sVOhwRFzxnq K+0HleDGGZ3oXLiQ10dKxHvdWuNr0gFfMsZrpUH8ssg1V2xCaWLrsZJe9zk7syQYXOplNMzMk oBlbYU78FHdT3XeTs7VRW7OFLc0EPziUH1wrCP9kFsZla6rhQIJL9gteoXu4n4LUvl6hh8fzJ BwZx1pLGqQ94WzicKUurMc83/1vJeb7guqAB2NOK2htSL/rJFZ+hhsFAbIz8vhUloN5s0Bpev Rjdnu7wkfDm1kkfb7bfID/7M5fabsL6AnchwgKOFO48kST3ALCHsPSj1AplDYE8NTSa/NzYsR AUevDLzZwD1shQbdeCsvQkDpDAXtKBW4fqDc89Br4ZWvFS4qwptpciH18bbzDI9FO32kaydIV WuYNExFFgDIoGr1P329WuKg8lSAp1VZ5a8Hf70t9EdZb/Bku81CREJH3cEoqfvS2IqqHaH3iK Wi7cgmujUE+My4RAAM/zXbXX/RtGX5BBbTdGftsR7oSanQ7BfEWqHfmXufZ0uw+NY+IIblqim hvRauTL57eAx3XmercojT7RAmb/mxwDJeBX1qxeFJ7wPnPo28BFGNzLN/pGAETGMvuUmYasD Received-SPF: pass client-ip=212.227.17.22; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268996 Archived-At: This is a multi-part message in MIME format. --------------2B25A8E4A17D31FDF25314E7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit >> please try the attached patch and tell me whether it helps. > > When I apply the patch to an unmodified xterm.c, emacs -Q has a menubar > but no toolbar, and the complete UI except for the menubar is just black > screen with no text, no modeline, no nothing! Even resizing or typing > won't make anything appear. The menubar works, though. I can expand it > and press entries, and it seems it reacts to that. > > When I apply your patch and also remove the second ifdef, that doesn't > change. Just a menubar with blackness on the rest of the frame. Thanks. That was a misguided attempt that didn't work here either. Please try the patch I attach now, it at least doesn't break anything here. If this still doesn't get us anywhere, I'd like to look into your frame size history and will tell you how to set that up. martin --------------2B25A8E4A17D31FDF25314E7 Content-Type: text/x-patch; name="xterm.c.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="xterm.c.diff" diff --git a/src/xterm.c b/src/xterm.c index 9edaed9a34..153089c1dc 100644 =2D-- a/src/xterm.c +++ b/src/xterm.c @@ -8438,14 +8438,16 @@ handle_one_xevent (struct x_display_info *dpyinfo, if (not_hidden) { - SET_FRAME_VISIBLE (f, 1); - SET_FRAME_ICONIFIED (f, false); #if defined USE_GTK && defined HAVE_GTK3 /* If GTK3 wants to impose some old size here (Bug#24526), tell it that the current size is what we want. */ - xg_frame_set_char_size - (f, FRAME_PIXEL_WIDTH (f), FRAME_PIXEL_HEIGHT (f)); + if (!FRAME_VISIBLE_P (f) || iconified) + xg_frame_set_char_size + (f, FRAME_PIXEL_WIDTH (f), FRAME_PIXEL_HEIGHT (f)); #endif + SET_FRAME_VISIBLE (f, 1); + SET_FRAME_ICONIFIED (f, false); + f->output_data.x->has_been_visible =3D true; } --------------2B25A8E4A17D31FDF25314E7--