From: Ken Brown <kbrown@cornell.edu>
To: emacs-devel@gnu.org
Subject: Re: unnecessary requirement of X11 for imagemagick in case of cygwin
Date: Thu, 13 Feb 2014 22:10:45 -0500 [thread overview]
Message-ID: <52FD8935.8010105@cornell.edu> (raw)
In-Reply-To: <COL131-W34207AB3320393A57A03F849D0@phx.gbl>
On 2/13/2014 10:52 AM, Mirek Kaim wrote:
> i've just compiled the latest version from repo under cygwin. imagemagick installed from cygwin package, with all dependecies - that includes some X-libs, but no X server per se. emacs configured --with-w32. all i did was this:
>
> diff --git a/configure.ac b/configure.ac
> index 326d528..bc95daa 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2236,7 +2236,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"
> fi
>
> HAVE_IMAGEMAGICK=no
> -if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then
> +#if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then
> if test "${with_imagemagick}" != "no"; then
> ## 6.2.8 is the earliest version known to work, but earlier versions
> ## might work - let us know if you find one.
> @@ -2254,7 +2254,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"
> AC_CHECK_FUNCS(MagickExportImagePixels MagickMergeImageLayers)
> fi
> fi
> -fi
> +#fi
>
>
> HAVE_GTK=no
>
> and it works, checked with image-dired and pdf page scaling. obviously, imagemagick is independent from the actual gui used by emacs - as long as there is a gui, it makes sense to link with it. shouldn't it be then:
>
> if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes" || test "${HAVE_W32}" = "yes"; then
>
> or am i missing something? i'm not too familiar with configure and makefile stuff, and i never submitted a patch so i don't have an account, so feel free to patch that.
This looks right to me, but I don't know enough about imagemagick to be
able to test it thoroughly. Maybe some imagemagick expert could
comment. In the meantime, I suggest you resend this as a bug report so
it doesn't get forgotten.
Ken
prev parent reply other threads:[~2014-02-14 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 15:52 unnecessary requirement of X11 for imagemagick in case of cygwin Mirek Kaim
2014-02-14 3:10 ` Ken Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FD8935.8010105@cornell.edu \
--to=kbrown@cornell.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).