From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Patches with independent changes Date: Sat, 25 Jan 2014 12:58:09 -0800 Organization: UCLA Computer Science Department Message-ID: <52E42561.4080807@cs.ucla.edu> References: <8361pbg5vy.fsf@gnu.org> <52E08D31.3080801@cs.ucla.edu> <8338kffj7m.fsf@gnu.org> <52E0A0ED.4020601@cs.ucla.edu> <83y526el6z.fsf@gnu.org> <52E18EC0.7090302@cs.ucla.edu> <83lhy5ests.fsf@gnu.org> <52E2277B.9000205@cs.ucla.edu> <83bnz1eo1x.fsf@gnu.org> <52E29827.7060209@cs.ucla.edu> <83ha8tcb4z.fsf@gnu.org> <52E2EA7B.2080501@cs.ucla.edu> <83fvoccyqt.fsf@gnu.org> <52E3EDE1.9050709@cs.ucla.edu> <83mwikas8w.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020006040903060700060500" X-Trace: ger.gmane.org 1390683511 12148 80.91.229.3 (25 Jan 2014 20:58:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Jan 2014 20:58:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 25 21:58:37 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W7AJJ-0006aq-6o for ged-emacs-devel@m.gmane.org; Sat, 25 Jan 2014 21:58:37 +0100 Original-Received: from localhost ([::1]:52506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7AJI-0003MC-S0 for ged-emacs-devel@m.gmane.org; Sat, 25 Jan 2014 15:58:36 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7AJ9-0003Lv-CR for emacs-devel@gnu.org; Sat, 25 Jan 2014 15:58:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7AJ2-00053M-2Z for emacs-devel@gnu.org; Sat, 25 Jan 2014 15:58:27 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:60638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7AIu-00052P-7l; Sat, 25 Jan 2014 15:58:12 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id D3EAC39E8011; Sat, 25 Jan 2014 12:58:10 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lGGFb1PqK3ap; Sat, 25 Jan 2014 12:58:10 -0800 (PST) Original-Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 60BBF39E8008; Sat, 25 Jan 2014 12:58:10 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: <83mwikas8w.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169081 Archived-At: This is a multi-part message in MIME format. --------------020006040903060700060500 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Eli Zaretskii wrote: > otherwise the build would have failed when compiler warnings are > turned on and used as errors. That would have been odd, as other static variables in Emacs are declared and set but never used (e.g., category_table_version) and evidently these builds are not failing. It's certainly OK to clean up the glitches, but such cleanups are independent changes. > Then any number of patches can be installed in a single commit, > because they are all "related" -- after all, they are all about Emacs. No, that's too broad. Patches should contain changes that are more closely-related than that. > you cannot chmod a file that is open ... the chmod call will fail. Where is this documented? Does the problem occur if any process has the file open, or only if the current process has it open? What is errno after the failure? This problem does not occur on POSIXish platforms; if it happens under Microsoft Windows the incompatibility should be documented (in Gnulib, if the problem is generic to GNU applications). > the fact that the problem could have been solved in more than > one way doesn't mean there are multiple changes involved. True, but if the problem could have been solved in a simpler way that involved fewer changes, then multiple changes were most likely present. Come to think of it, why is that chmod needed at all in WINDOWSNT? The file is already readable and writeable, so as I understand it chmod 644 is therefore a no-op on that platform. If so, the attached patch would have been simpler yet, no? --------------020006040903060700060500 Content-Type: text/x-patch; name="update1.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="update1.diff" --- update-game-score.c-old 2014-01-25 08:31:13.065305429 -0800 +++ update-game-score.c 2014-01-25 11:56:15.570846522 -0800 @@ -443,8 +443,10 @@ fd = mkostemp (tempfile, 0); if (fd < 0) return -1; +#ifndef WINDOWSNT if (fchmod (fd, 0644) != 0) return -1; +#endif f = fdopen (fd, "w"); if (! f) return -1; --------------020006040903060700060500--