From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Patches with independent changes Date: Fri, 24 Jan 2014 14:34:35 -0800 Organization: UCLA Computer Science Department Message-ID: <52E2EA7B.2080501@cs.ucla.edu> References: <8361pbg5vy.fsf@gnu.org> <52E08D31.3080801@cs.ucla.edu> <8338kffj7m.fsf@gnu.org> <52E0A0ED.4020601@cs.ucla.edu> <83y526el6z.fsf@gnu.org> <52E18EC0.7090302@cs.ucla.edu> <83lhy5ests.fsf@gnu.org> <52E2277B.9000205@cs.ucla.edu> <83bnz1eo1x.fsf@gnu.org> <52E29827.7060209@cs.ucla.edu> <83ha8tcb4z.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1390602898 18977 80.91.229.3 (24 Jan 2014 22:34:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jan 2014 22:34:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 24 23:35:04 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W6pL5-0003KL-A4 for ged-emacs-devel@m.gmane.org; Fri, 24 Jan 2014 23:35:03 +0100 Original-Received: from localhost ([::1]:49160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6pL4-000143-KV for ged-emacs-devel@m.gmane.org; Fri, 24 Jan 2014 17:35:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6pKu-00012X-HI for emacs-devel@gnu.org; Fri, 24 Jan 2014 17:34:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6pKn-0002Vs-7x for emacs-devel@gnu.org; Fri, 24 Jan 2014 17:34:52 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:46604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6pKf-0002UE-GO; Fri, 24 Jan 2014 17:34:37 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 5A75B39E8014; Fri, 24 Jan 2014 14:34:36 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vxGPrHphh753; Fri, 24 Jan 2014 14:34:36 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id BB65039E8008; Fri, 24 Jan 2014 14:34:35 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: <83ha8tcb4z.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169034 Archived-At: On 01/24/2014 01:39 PM, Eli Zaretskii wrote: > they both address the fact that fchmod is not available on Windows. > One without the other would break the build on Windows. I wasn't referring to two hunks in the patch. I was referring to two of the changes installed by that patch. One change worked around WINDOWSNT's lack of fchmod, and the other replaced "!=" with "<".The changes were independent and only the first change was needed to fix the bug. > That I used < rather than != is immaterial You thought replacing "!=" with "<" was needed, so the intent of that patch was to install multiple independent fixes. Which was fine. Here's another example. Trunk bzr 116064 fixes a file name handling failure on MS-Windows 9X. While it's in the neighborhood, it makes the independent changes of removing initialization code for the variable g_b_init_is_w9x, and of removing that variable's definition. These independent changes weren't needed to fix the bug. This sort of thing is quite common, and there's nothing wrong with it. >> [retitling from "Changes in update-game-score.c"] > [Why?] Others requested retitling and this seemed reasonable.