From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Changes in update-game-score.c Date: Fri, 24 Jan 2014 00:42:35 -0800 Organization: UCLA Computer Science Department Message-ID: <52E2277B.9000205@cs.ucla.edu> References: <8361pbg5vy.fsf@gnu.org> <52E08D31.3080801@cs.ucla.edu> <8338kffj7m.fsf@gnu.org> <52E0A0ED.4020601@cs.ucla.edu> <83y526el6z.fsf@gnu.org> <52E18EC0.7090302@cs.ucla.edu> <83lhy5ests.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000101040801070305050307" X-Trace: ger.gmane.org 1390552986 28208 80.91.229.3 (24 Jan 2014 08:43:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jan 2014 08:43:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 24 09:43:13 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W6cM4-0002KP-1M for ged-emacs-devel@m.gmane.org; Fri, 24 Jan 2014 09:43:12 +0100 Original-Received: from localhost ([::1]:45060 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6cM3-0002hv-Ls for ged-emacs-devel@m.gmane.org; Fri, 24 Jan 2014 03:43:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6cLv-0002Z7-Lt for emacs-devel@gnu.org; Fri, 24 Jan 2014 03:43:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6cLq-0002CY-IN for emacs-devel@gnu.org; Fri, 24 Jan 2014 03:43:03 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:35429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6cLk-0002B8-Mi; Fri, 24 Jan 2014 03:42:52 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 504E3A60003; Fri, 24 Jan 2014 00:42:45 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sS4S0xGHWfaa; Fri, 24 Jan 2014 00:42:44 -0800 (PST) Original-Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 64D21A60002; Fri, 24 Jan 2014 00:42:44 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: <83lhy5ests.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168999 Archived-At: This is a multi-part message in MIME format. --------------000101040801070305050307 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Eli Zaretskii wrote: > sumo changesets make maintenance harder Sure, but the change that prompted this thread (trunk bzr 116113) deleted 13 lines of code and added 8. That's a small changeset, not a sumo one. > the comparison is invalid because this [other] change wasn't fixing any bug, it's more like whitespace cleanup. It's easy to find bug-fixing changes that behave the same way. For example, the most recent bug-fixing patch that you installed (attached) actually consists of multiple independent changes. One change replaces fchmod with chmod on WINDOWSNT platforms, fixing a porting bug; but another change replaces "!=" with "<" on WINDOWSNT, and this change does not fix any bug. This sort of thing happens all the time, and it's OK. It'd be unreasonable to insist that every patch to Emacs now must fix just one bug and must not make any changes that do not fix the bug. --------------000101040801070305050307 Content-Type: text/x-patch; name="w32.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="w32.diff" === modified file 'lib-src/ChangeLog' --- lib-src/ChangeLog 2014-01-22 19:02:41 +0000 +++ lib-src/ChangeLog 2014-01-22 19:38:31 +0000 @@ -1,3 +1,8 @@ +2014-01-22 Eli Zaretskii + + * update-game-score.c (write_scores) [WINDOWSNT]: Use chmod + instead of fchmod. + 2014-01-22 Paul Eggert Fix miscellaneous update-game-score bugs. === modified file 'lib-src/update-game-score.c' --- lib-src/update-game-score.c 2014-01-22 19:02:41 +0000 +++ lib-src/update-game-score.c 2014-01-22 19:38:31 +0000 @@ -443,8 +443,10 @@ fd = mkostemp (tempfile, 0); if (fd < 0) return -1; +#ifndef WINDOWSNT if (fchmod (fd, 0644) != 0) return -1; +#endif f = fdopen (fd, "w"); if (! f) return -1; @@ -457,6 +459,10 @@ return -1; if (rename (tempfile, filename) != 0) return -1; +#ifdef WINDOWSNT + if (chmod (filename, 0644) < 0) + return -1; +#endif return 0; } --------------000101040801070305050307--