From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: One more warning about using an uninitialized field Date: Thu, 23 Jan 2014 13:08:18 +0400 Message-ID: <52E0DC02.3090203@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1390468115 13797 80.91.229.3 (23 Jan 2014 09:08:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Jan 2014 09:08:35 +0000 (UTC) Cc: Emacs development discussions To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 23 10:08:42 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W6GHC-0002mI-53 for ged-emacs-devel@m.gmane.org; Thu, 23 Jan 2014 10:08:42 +0100 Original-Received: from localhost ([::1]:39591 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6GHB-0007Id-EF for ged-emacs-devel@m.gmane.org; Thu, 23 Jan 2014 04:08:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6GH0-00079X-St for emacs-devel@gnu.org; Thu, 23 Jan 2014 04:08:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6GGs-00034x-Vk for emacs-devel@gnu.org; Thu, 23 Jan 2014 04:08:30 -0500 Original-Received: from forward10l.mail.yandex.net ([2a02:6b8:0:1819::a]:48357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6GGs-00034c-D0 for emacs-devel@gnu.org; Thu, 23 Jan 2014 04:08:22 -0500 Original-Received: from smtp1h.mail.yandex.net (smtp1h.mail.yandex.net [84.201.187.144]) by forward10l.mail.yandex.net (Yandex) with ESMTP id 3D2D9BA0F3C; Thu, 23 Jan 2014 13:08:20 +0400 (MSK) Original-Received: from smtp1h.mail.yandex.net (localhost [127.0.0.1]) by smtp1h.mail.yandex.net (Yandex) with ESMTP id C51911340277; Thu, 23 Jan 2014 13:08:19 +0400 (MSK) Original-Received: from unknown (unknown [37.139.80.10]) by smtp1h.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 65rmw8xpUG-8JdWZRPX; Thu, 23 Jan 2014 13:08:19 +0400 (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (Client certificate not present) X-Yandex-Uniq: 7e38242d-5b7f-4b96-b1f8-5649aebe553f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1390468099; bh=9/H6tvMP9USY8RNmE1HERF+s7k0jJ0K+xANdxQY2YK4=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: Content-Type:Content-Transfer-Encoding; b=plwMOA971A/Dndl+QNw9odKrUSkWosfjTw/0LaZPqIiLdpORH7nadcsAakW6LxweT bPWRYHMiQyPcOTjjKQfBjBqd+ZHkJxPsW64Md3euKid3W3/AdG1otu60Q5x1xrAjIG BM5YY7u2wV+xFlCA65HbXqQ70lfwZXefJsUK4Rkg= Authentication-Results: smtp1h.mail.yandex.net; dkim=pass header.i=@yandex.ru User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a02:6b8:0:1819::a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168939 Archived-At: One more warning about using an uninitialized field, now BIDI-related: ==11279== Conditional jump or move depends on uninitialised value(s) ==11279== at 0x443145: compute_display_string_pos (xdisp.c:3582) ==11279== by 0x500D93: bidi_fetch_char (bidi.c:953) ==11279== by 0x501FF9: bidi_paragraph_init (bidi.c:1299) ==11279== by 0x47AEAE: Fcurrent_bidi_paragraph_direction (xdisp.c:20419) From xdisp.c: 3579 if (charpos >= eob 3580 /* We don't support display properties whose values are strings 3581 that have display string properties. */ ! 3582 || string->from_disp_str 3583 /* C strings cannot have display properties. */ 3584 || (string->s && !STRINGP (object))) 3585 { 3586 *disp_prop = 0; 3587 return eob; 3588 } I don't know how critical it may be, but please consider the following precaution: === modified file 'src/xdisp.c' --- src/xdisp.c 2014-01-13 11:30:30 +0000 +++ src/xdisp.c 2014-01-23 08:53:41 +0000 @@ -6409,6 +6409,7 @@ it->bidi_it.string.s = NULL; it->bidi_it.string.lstring = Qnil; it->bidi_it.string.bufpos = 0; + it->bidi_it.string.from_disp_str = 0; it->bidi_it.string.unibyte = 0; it->bidi_it.w = it->w; } @@ -20411,6 +20412,7 @@ itb.string.s = NULL; itb.string.lstring = Qnil; itb.string.bufpos = 0; + itb.string.from_disp_str = 0; itb.string.unibyte = 0; /* We have no window to use here for ignoring window-specific overlays. Using NULL for window pointer will cause Dmitry