From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: The fixes-bug field Date: Thu, 16 Jan 2014 23:58:23 -0800 Organization: UCLA Computer Science Department Message-ID: <52D8E29F.6040004@cs.ucla.edu> References: <20140116141315.CA3BE380835@snark.thyrsus.com> <20140116163011.GC17303@thyrsus.com> <83d2jr3ly9.fsf@gnu.org> <20140116180809.GB17770@thyrsus.com> <8338kn3ha8.fsf@gnu.org> <20140116200456.GK17770@thyrsus.com> <83zjmv1upy.fsf@gnu.org> <20140116214714.GA19493@thyrsus.com> <83sisn12sk.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1389945521 21231 80.91.229.3 (17 Jan 2014 07:58:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jan 2014 07:58:41 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii , esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 17 08:58:47 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W44KE-0000pb-Ls for ged-emacs-devel@m.gmane.org; Fri, 17 Jan 2014 08:58:46 +0100 Original-Received: from localhost ([::1]:36702 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W44KE-0003yP-CH for ged-emacs-devel@m.gmane.org; Fri, 17 Jan 2014 02:58:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W44K5-0003xs-Nc for emacs-devel@gnu.org; Fri, 17 Jan 2014 02:58:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W44Jz-00072J-S9 for emacs-devel@gnu.org; Fri, 17 Jan 2014 02:58:37 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:40824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W44Jt-0006zA-HG; Fri, 17 Jan 2014 02:58:25 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 8EA1BA60004; Thu, 16 Jan 2014 23:58:24 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GJKrSx0SDdJI; Thu, 16 Jan 2014 23:58:24 -0800 (PST) Original-Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id CFBAEA60002; Thu, 16 Jan 2014 23:58:23 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: <83sisn12sk.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168593 Archived-At: Eli Zaretskii wrote: > If this information will be in the commit message (one suggestion so > far, AFAIU), we should define its precise format and location within > the commit message. Let's define the format that we're already using in ChangeLog entries. That is, a commit message that contains the string "Bug#16372" is related to Bug#16372. This would be simpler and more natural than what we're doing now. For example, with bzr, this ChangeLog entry: 2014-01-07 Paul Eggert Fix misdisplay of interlaced GIFs with libgif5 (Bug#16372). * image.c (gif_load): libgif5 deinterlaces for us, so don't do it again. corresponds to this commit message in trunk bzr 115915: Fix misdisplay of interlaced GIFs with libgif5. * image.c (gif_load): libgif5 deinterlaces for us, so don't do it again. and means that the change is related to Bug#16372. With git, I'd prefer using a commit message that matches what's in the ChangeLog entry, as that's simpler anyway. I.e., I'd rather use this commit message: Fix misdisplay of interlaced GIFs with libgif5 (Bug#16372). * image.c (gif_load): libgif5 deinterlaces for us, so don't do it again. This way, I could use vanilla vc-dwim to check in my changes, rather the current song and dance where the commit message doesn't quite match the ChangeLog entry (as the Bug# is missing) and I run bzr with the --fixes option to communicate the Bug#.