From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115886: Fix defun navigation in vc log view. Date: Mon, 06 Jan 2014 07:08:27 -0800 Message-ID: <52CAC6EB.9000308@dancol.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1389020919 6069 80.91.229.3 (6 Jan 2014 15:08:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Jan 2014 15:08:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 06 16:08:47 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W0BnF-0004Qp-Lz for ged-emacs-devel@m.gmane.org; Mon, 06 Jan 2014 16:08:41 +0100 Original-Received: from localhost ([::1]:35738 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0BnF-00061B-6N for ged-emacs-devel@m.gmane.org; Mon, 06 Jan 2014 10:08:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0BnC-000613-5v for emacs-devel@gnu.org; Mon, 06 Jan 2014 10:08:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Bn9-0001g0-Q4 for emacs-devel@gnu.org; Mon, 06 Jan 2014 10:08:38 -0500 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:47878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Bn9-0001fm-7P for emacs-devel@gnu.org; Mon, 06 Jan 2014 10:08:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=xh1mmU5y568+/7kh6PtdYZoUN9jYnqwOUFG2Al2NlcQ=; b=jCKGWQSN9Tw9gGRLpbgvhG6Pf1T6gvfdmq9SjTUuMz1uYH13knnSS7hrXqm4YEukf2THWNUAdkaCcgfrOnB5U6KRdvj5S9vKvbzrr5TN0/tIP3DPDmusIplvDJ9U2GE9u5YesgMU+iFvEg4e+iUV1xwY/LzcvukWkp9UGBytHSgahrfn4YSViYcTly/j95Zz8QQ+d8qMrMY76LWY8oLHfekXDejThqfLz/I5w3DZvoOtbCj/ATTjyJR6X7wiZVBilwDQBxiiE62Cb3IPpWiHspni11hUlFLI6jdssHP8Q+apPtszamHjtAb1s6AfUVpQd6PNsbUKTCie/bmZbVlGEw==; Original-Received: from [2620:0:1cfe:99::1] by dancol.org with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1W0Bn8-0006gM-Cg; Mon, 06 Jan 2014 07:08:34 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167471 Archived-At: On 01/06/2014 07:05 AM, Stefan Monnier wrote: >> + Fix defun navigation in vc log view. > [...] >> (if (< arg 0) >> + (log-view-end-of-defun (- arg)) > > This looks very fishy. beginning-of-defun-function should never move to > the end of a defun, even when called with a negative argument. In the vc log case, the end of the defun is the beginning of the next, so in this case, the code should be correct. > So, if this is really correct, it needs a comment explaining why this is > the right thing to do. And if you could add some regression tests for your > commit it would be even better. Sure.