From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Problems with --enable-gcc-warnings Date: Tue, 17 Dec 2013 12:49:03 -0800 Organization: UCLA Computer Science Department Message-ID: <52B0B8BF.9020409@cs.ucla.edu> References: <83ppovcqcf.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1387313366 10022 80.91.229.3 (17 Dec 2013 20:49:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Dec 2013 20:49:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 17 21:49:31 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vt1a6-00017I-TX for ged-emacs-devel@m.gmane.org; Tue, 17 Dec 2013 21:49:31 +0100 Original-Received: from localhost ([::1]:35343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vt1a6-0006ew-IL for ged-emacs-devel@m.gmane.org; Tue, 17 Dec 2013 15:49:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vt1Zx-0006dk-Db for emacs-devel@gnu.org; Tue, 17 Dec 2013 15:49:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vt1Zq-0000Le-3b for emacs-devel@gnu.org; Tue, 17 Dec 2013 15:49:21 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:40375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vt1Zh-0000LH-92; Tue, 17 Dec 2013 15:49:05 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id CBE0C39E80F8; Tue, 17 Dec 2013 12:49:04 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aUI13G7tmBVo; Tue, 17 Dec 2013 12:49:04 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 5CEE739E8008; Tue, 17 Dec 2013 12:49:04 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: <83ppovcqcf.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166557 Archived-At: On 12/17/2013 09:57 AM, Eli Zaretskii wrote: > it seems like older compilers have trouble with some of the > warning options. Yes, --enable-gcc-warnings is currently not supported for older GCC releases. We've found it's enough of a pain keeping it working for relatively-recent releases. Currently I suspect it really needs 4.6 or later; maybe even 4.7. Since it's a build-time option, we have been suggesting to simply not use it if your compiler's old. If you'd like to add support for older GCC releases, please feel free to hack on gnulib and submit a patch; the relevant files are m4/manywarnings.m4 and m4/warnings.m4. > Then I had a warning in lib/file-has-acl.c, because under some > conditions the acl_access_nontrivial doesn't return a value (look near > its end). I tried to fix that in trunk bzr 115573. > Lastly, the INT_BUFSIZE_BOUND macro seems to be unable to support > 'void *' as its argument without emitting warnings, I need to use > intptr_t instead to pacify the compiler. That's expected; the argument of INT_BUFSIZE_BOUND must be an integer type or expression. This info is in the prefatory comment. It might be nice to have a bound for void * too, for printf %p formats. It'd have to be a different macro though, I expect.