unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Problems with --enable-gcc-warnings
Date: Tue, 17 Dec 2013 12:49:03 -0800	[thread overview]
Message-ID: <52B0B8BF.9020409@cs.ucla.edu> (raw)
In-Reply-To: <83ppovcqcf.fsf@gnu.org>

On 12/17/2013 09:57 AM, Eli Zaretskii wrote:
> it seems like older compilers have trouble with some of the
> warning options.

Yes, --enable-gcc-warnings is currently not supported for older GCC
releases.  We've found it's enough of a pain keeping it working for
relatively-recent releases.  Currently I suspect it really needs 4.6
or later; maybe even 4.7.  Since it's a build-time option, we have
been suggesting to simply not use it if your compiler's old.

If you'd like to add support for older GCC releases, please feel free
to hack on gnulib and submit a patch; the relevant files are
m4/manywarnings.m4 and m4/warnings.m4.

> Then I had a warning in lib/file-has-acl.c, because under some
> conditions the acl_access_nontrivial doesn't return a value (look near
> its end).

I tried to fix that in trunk bzr 115573.

> Lastly, the INT_BUFSIZE_BOUND macro seems to be unable to support
> 'void *' as its argument without emitting warnings, I need to use
> intptr_t instead to pacify the compiler.

That's expected; the argument of INT_BUFSIZE_BOUND must be an integer
type or expression.  This info is in the prefatory comment.

It might be nice to have a bound for void * too, for printf %p formats.
It'd have to be a different macro though, I expect.



  reply	other threads:[~2013-12-17 20:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 17:57 Problems with --enable-gcc-warnings Eli Zaretskii
2013-12-17 20:49 ` Paul Eggert [this message]
2013-12-17 21:08   ` Eli Zaretskii
2013-12-17 22:20     ` Paul Eggert
2013-12-18  3:50       ` Eli Zaretskii
2013-12-18  4:13         ` Paul Eggert
2013-12-18 16:17           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B0B8BF.9020409@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).