From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers.
Date: Sat, 30 Nov 2013 18:02:16 +0200 [thread overview]
Message-ID: <529A0C08.8010809@yandex.ru> (raw)
In-Reply-To: <jwvpppi8wym.fsf-monnier+emacs@gnu.org>
On 30.11.2013 04:29, Stefan Monnier wrote:
> Note that a solution that applies only to ChangeLog wouldn't help for
> the `elpa' branch. And hopefully at some point it won't help for
> `emacs' either because we'll have finally rid ourselves of the
> ChangeLog files.
Ok, good point. If other contributors have no new suggestions, I'll be
content with a user option.
> We could easily highlight Summary specially after the Nth character.
> [ Not sure why it should be 50, and that number might need to
> depend on the backend, but other than that, I don't see
> any particular difficulty. ]
50 is just a convention, so it shouldn't be inherently different for any
other backend. And a safe-local user option will allow users to set it
per project.
>> Actually, now that I've checked, `C-c C-k' in both `message-mode' and
>> git-commit-mode' that Magit uses kill the buffer after doing some cleanup,
>> not bury it. Would you be fine with that?
>
> Seems a bit pointless since C-x k (and kill-this-buffer) works as well
> for *VC-Log*, AFAIK.
Why do we have `message-kill-buffer', `rcirc-multiline-minor-cancel' and
`org-kill-note-or-show-branches'?
As I see it, they mean "abort the current action, clean up its data,
restore the previous window configuration". Having a similar command
with the same binding in log-edit would be natural. Among other things,
it would delete the *log-edit-files* window and quit-window on the
current buffer (maybe deleting the window as a result).
We can go against the similar commands and refrain from killing the
buffer, but why keep it? We can also save the aborted commit message to
log-edit-comment-ring.
>> I think it can look better than using a separate window. But then again,
>> it's how other editors do it, so it might just be more familiar.
>
> I used a separate window because it seemed easier, avoiding the usual
> problems with display-only-text or with text-that-will-disappear, which
> both can lead to surprising behaviors for the unsuspecting user.
Ok, I can work with either approach.
next prev parent reply other threads:[~2013-11-30 16:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VlqjS-0006O3-Fn@vcs.savannah.gnu.org>
2013-11-29 4:39 ` trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers Dmitry Gutov
2013-11-29 13:33 ` Stefan Monnier
2013-11-29 14:53 ` Dmitry Gutov
2013-11-29 17:04 ` Stefan Monnier
2013-11-29 22:37 ` Dmitry Gutov
2013-11-30 2:29 ` Stefan Monnier
2013-11-30 16:02 ` Dmitry Gutov [this message]
2013-12-01 21:10 ` Stefan Monnier
2013-12-02 2:40 ` Dmitry Gutov
2013-12-02 13:53 ` Stefan Monnier
2013-12-02 23:02 ` Dmitry Gutov
2013-12-03 0:56 ` Leo Liu
2013-12-03 3:06 ` Stefan Monnier
2013-12-04 0:38 ` Dmitry Gutov
2013-12-03 2:17 ` Dmitry Gutov
2013-12-03 3:09 ` Stefan Monnier
2013-12-04 0:43 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529A0C08.8010809@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).