From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Stuart D. Herring" Newsgroups: gmane.emacs.devel Subject: Re: autoloads for safe-local-variables (was: allout patch - moresafe-local-variables, plus autoloads) Date: Thu, 20 Apr 2006 12:52:20 -0700 (PDT) Message-ID: <52840.128.165.0.81.1145562740.squirrel@webmail.lanl.gov> References: <2cd46e7f0604171211s5ef0e820gebc4e68b2ce2606d@mail.gmail.com><2cd46e7f0604191608o52f500ferc1955a131bd5fde4@mail.gmail.com> Reply-To: herring@lanl.gov NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1145562768 22277 80.91.229.2 (20 Apr 2006 19:52:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 20 Apr 2006 19:52:48 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 20 21:52:46 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FWfCn-0004Le-VE for ged-emacs-devel@m.gmane.org; Thu, 20 Apr 2006 21:52:46 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FWfCn-0000Gn-FA for ged-emacs-devel@m.gmane.org; Thu, 20 Apr 2006 15:52:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FWfCY-0000Ee-U8 for emacs-devel@gnu.org; Thu, 20 Apr 2006 15:52:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FWfCY-0000EQ-11 for emacs-devel@gnu.org; Thu, 20 Apr 2006 15:52:30 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FWfCX-0000EN-Oq for emacs-devel@gnu.org; Thu, 20 Apr 2006 15:52:29 -0400 Original-Received: from [192.65.95.54] (helo=mailwasher-b.lanl.gov) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FWfDv-0006y7-Qr for emacs-devel@gnu.org; Thu, 20 Apr 2006 15:53:56 -0400 Original-Received: from mailrelay3.lanl.gov (mailrelay3.lanl.gov [128.165.4.104]) by mailwasher-b.lanl.gov (8.12.11.20060308/8.12.11/(ccn-5)) with ESMTP id k3KJqNR2019235 for ; Thu, 20 Apr 2006 13:52:23 -0600 Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay3.lanl.gov (8.12.11.20060308/8.12.11/(ccn-5)) with ESMTP id k3KJqK2H030444; Thu, 20 Apr 2006 13:52:20 -0600 Original-Received: from webmail1.lanl.gov (localhost.localdomain [127.0.0.1]) by webmail1.lanl.gov (8.12.11.20060308/8.12.11) with ESMTP id k3KJqK6a029305; Thu, 20 Apr 2006 13:52:20 -0600 Original-Received: (from apache@localhost) by webmail1.lanl.gov (8.12.11.20060308/8.12.11/Submit) id k3KJqKLq029303; Thu, 20 Apr 2006 12:52:20 -0700 X-Authentication-Warning: webmail1.lanl.gov: apache set sender to herring@lanl.gov using -f Original-Received: from 128.165.0.81 (SquirrelMail authenticated user 196434); by webmail.lanl.gov with HTTP; Thu, 20 Apr 2006 12:52:20 -0700 (PDT) In-Reply-To: Original-To: "Reiner Steib" User-Agent: SquirrelMail/1.4.3a-11.EL3 X-Mailer: SquirrelMail/1.4.3a-11.EL3 X-Priority: 3 (Normal) Importance: Normal X-PMX-Version: 4.7.1.128075 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53157 Archived-At: >> +;;;###autoload >> +(put 'allout-show-bodies 'safe-local-variable t) > > In my commits, I've put in the same line... > > ;;;###autoload(put 'page-delimiter 'safe-local-variable t) > > ... like it is done e.g. in `code-pages.el': > > ;;;###autoload(autoload-coding-system 'cp437 '(require 'code-pages)) > > Which style is preferable? The first style leaves the code as active code, executed when the file is loaded. The second style generates no code in file.elc but only in loaddefs.el. So if it's logically part of the library, you want the first form; if it's some sort of reference to the library, but not really part of it, like the code-pages example, you want the second one. For a simple (put ...) it probably doesn't matter too much, but it probably would interact better with, say, unload-feature to use the first one. This gets me thinking, though -- does unload-feature remove plists from symbols it's dumping? If so, shouldn't it not remove the `risky-local-variable' property if any? Apologies if this is just confusion. Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.