From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'. Date: Sat, 12 Oct 2013 00:37:03 -0700 Organization: UCLA Computer Science Department Message-ID: <5258FC1F.8080603@cs.ucla.edu> References: <52576305.9000703@dancol.org> <52579C68.1040904@cs.ucla.edu> <83iox4pa0w.fsf@gnu.org> <5257AB8C.40309@dancol.org> <83eh7sp6v0.fsf@gnu.org> <5257B489.2050609@dancol.org> <83k3hkrxao.fsf@gnu.org> <5257C27B.9090400@dancol.org> <83hacorvww.fsf@gnu.org> <5257CB20.4030809@dancol.org> <5257D36B.4090305@yandex.ru> <52581799.3060501@cs.ucla.edu> <52581C44.5070207@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1381563439 19250 80.91.229.3 (12 Oct 2013 07:37:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Oct 2013 07:37:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 12 09:37:23 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VUtlK-0003eu-Ld for ged-emacs-devel@m.gmane.org; Sat, 12 Oct 2013 09:37:22 +0200 Original-Received: from localhost ([::1]:57295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUtlK-0003QV-7h for ged-emacs-devel@m.gmane.org; Sat, 12 Oct 2013 03:37:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUtlB-0003Q9-4C for emacs-devel@gnu.org; Sat, 12 Oct 2013 03:37:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUtl3-0007BM-Qc for emacs-devel@gnu.org; Sat, 12 Oct 2013 03:37:13 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:39950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUtl3-0007BH-Ky for emacs-devel@gnu.org; Sat, 12 Oct 2013 03:37:05 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id C2590A60009; Sat, 12 Oct 2013 00:37:04 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UWu4Y7-JEm2a; Sat, 12 Oct 2013 00:37:04 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 5D8EDA60008; Sat, 12 Oct 2013 00:37:04 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 In-Reply-To: <52581C44.5070207@dancol.org> X-Enigmail-Version: 1.5.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164131 Archived-At: Daniel Colascione wrote: > I haven't seen a single instance of a correct, side-effect-free assume resulting in incorrect code generation. As far as I could tell, the generated code wasn't incorrect, it was merely slower. I didn't measure the performance, but the generated code did look worse (I could have been mistaken of course). Have you measured the user-visible performance of Emacs when it internally uses eassume rather than eassert? Is there a significant performance improvement? If not, perhaps we should omit eassume, as not being worth the trouble.