From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'. Date: Thu, 10 Oct 2013 19:31:33 -0700 Message-ID: <52576305.9000703@dancol.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1381458717 18450 80.91.229.3 (11 Oct 2013 02:31:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Oct 2013 02:31:57 +0000 (UTC) To: Paul Eggert , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 11 04:32:01 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VUSWC-00029n-64 for ged-emacs-devel@m.gmane.org; Fri, 11 Oct 2013 04:31:56 +0200 Original-Received: from localhost ([::1]:52165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUSWB-0000PC-KE for ged-emacs-devel@m.gmane.org; Thu, 10 Oct 2013 22:31:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUSW4-0000P4-Ev for emacs-devel@gnu.org; Thu, 10 Oct 2013 22:31:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUSW3-0004cY-Bm for emacs-devel@gnu.org; Thu, 10 Oct 2013 22:31:48 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:46066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUSW3-0004YE-64 for emacs-devel@gnu.org; Thu, 10 Oct 2013 22:31:47 -0400 Original-Received: from [2620:0:1cfe:18:cc80:35d0:d3e8:9b79] (helo=dcolascione-mbp.local) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1VUSVw-0000bA-Ak; Thu, 10 Oct 2013 19:31:40 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Thunderbird/24.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164072 Archived-At: On 10/9/13 10:52 AM, Paul Eggert wrote: > ------------------------------------------------------------ > revno: 114593 > revision-id: eggert@cs.ucla.edu-20131009175238-dkbu5sk6zbqznw80 > parent: rgm@gnu.org-20131009171720-4kzu0813fkap59g3 > committer: Paul Eggert > branch nick: trunk > timestamp: Wed 2013-10-09 10:52:38 -0700 > message: > * lisp.h (eassert): Don't use 'assume'. > > Sometimes 'assume' wins in performance, and sometimes it loses, > so it shouldn't be used all the time. Perhaps we need two > flavors of 'eassert', one for where 'assume' is far more likely > to help or to hurt; but that can be done later. > Problem reported by Dmitry Andipov in > . > Also, don't include ; no longer needed. Can you please either 1) restore eassert_and_assume and its callers or 20 restore the assume calls in alloc.c and data.c? By merging eassert_and_assume with eassert, then removing the assume from eassert, you've essentially removed calls to assume and pessimized the code.