From: Daniel Colascione <dancol@dancol.org>
To: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'.
Date: Thu, 10 Oct 2013 19:31:33 -0700 [thread overview]
Message-ID: <52576305.9000703@dancol.org> (raw)
In-Reply-To: <E1VTxwB-0001h8-7E@vcs.savannah.gnu.org>
On 10/9/13 10:52 AM, Paul Eggert wrote:
> ------------------------------------------------------------
> revno: 114593
> revision-id: eggert@cs.ucla.edu-20131009175238-dkbu5sk6zbqznw80
> parent: rgm@gnu.org-20131009171720-4kzu0813fkap59g3
> committer: Paul Eggert <eggert@cs.ucla.edu>
> branch nick: trunk
> timestamp: Wed 2013-10-09 10:52:38 -0700
> message:
> * lisp.h (eassert): Don't use 'assume'.
>
> Sometimes 'assume' wins in performance, and sometimes it loses,
> so it shouldn't be used all the time. Perhaps we need two
> flavors of 'eassert', one for where 'assume' is far more likely
> to help or to hurt; but that can be done later.
> Problem reported by Dmitry Andipov in
> <http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00276.html>.
> Also, don't include <verify.h>; no longer needed.
Can you please either 1) restore eassert_and_assume and its callers or
20 restore the assume calls in alloc.c and data.c? By merging
eassert_and_assume with eassert, then removing the assume from eassert,
you've essentially removed calls to assume and pessimized the code.
next parent reply other threads:[~2013-10-11 2:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VTxwB-0001h8-7E@vcs.savannah.gnu.org>
2013-10-11 2:31 ` Daniel Colascione [this message]
2013-10-11 6:36 ` [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume' Paul Eggert
2013-10-11 7:00 ` Eli Zaretskii
2013-10-11 7:41 ` Daniel Colascione
2013-10-11 8:08 ` Eli Zaretskii
2013-10-11 8:19 ` Daniel Colascione
2013-10-11 8:59 ` Stephen J. Turnbull
2013-10-11 9:10 ` Daniel Colascione
2013-10-11 10:27 ` Stephen J. Turnbull
2013-10-11 12:42 ` Stefan Monnier
2013-10-11 15:24 ` Stephen J. Turnbull
2013-10-11 9:06 ` Eli Zaretskii
2013-10-11 9:18 ` Daniel Colascione
2013-10-11 9:36 ` Eli Zaretskii
2013-10-11 9:55 ` Daniel Colascione
2013-10-11 10:31 ` Dmitry Antipov
2013-10-11 15:22 ` Paul Eggert
2013-10-11 15:41 ` Daniel Colascione
2013-10-12 7:37 ` Paul Eggert
2013-10-11 11:19 ` Eli Zaretskii
2013-10-11 15:57 ` Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52576305.9000703@dancol.org \
--to=dancol@dancol.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).