From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r114556: * test/indent/ruby.rb: Fix a spurious change, add more failing examples. Date: Wed, 09 Oct 2013 06:27:21 +0300 Message-ID: <5254CD19.4060301@yandex.ru> References: <87y564hecg.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1381289263 23071 80.91.229.3 (9 Oct 2013 03:27:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Oct 2013 03:27:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 09 05:27:45 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VTkR7-00038J-1c for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2013 05:27:45 +0200 Original-Received: from localhost ([::1]:40028 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTkR6-0004Su-Kx for ged-emacs-devel@m.gmane.org; Tue, 08 Oct 2013 23:27:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTkQw-0004Sk-Ef for emacs-devel@gnu.org; Tue, 08 Oct 2013 23:27:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTkQo-0003js-2q for emacs-devel@gnu.org; Tue, 08 Oct 2013 23:27:34 -0400 Original-Received: from mail-ee0-x22e.google.com ([2a00:1450:4013:c00::22e]:50296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTkQn-0003jS-Ro for emacs-devel@gnu.org; Tue, 08 Oct 2013 23:27:25 -0400 Original-Received: by mail-ee0-f46.google.com with SMTP id c13so78214eek.33 for ; Tue, 08 Oct 2013 20:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=6cpFvrpYvB9Obv0L31CJUihjQSsmmjxssdicYMl0lKM=; b=0CeDvJm/Qc+fHnFl5asyVNXprISNrw2vFD6PrE8ghsiR3YW+eSvtyjvIzuf/y5kpln bFHQM1xxlUdwOZGdsiUuQp5G7oe3rMhhR8SJEyjesZntNpdyCSnKTLPVYHkmHdHskFT+ JuwyQrGY2hToZ1uGnl6QESygmBvDSeOs71dMiD2jg3NU11DLpRS/P/og5jI256LAOMLH Ea//barxPSZuy15kc9lTZEXbkrJNU+GIQJ7tdNleP5PImz6XhdJDAlfDzCY8VWUz+ZPV pX5AY+YrIL23oU++lO5zk7PQmIOy9mc1y7/4+NI44L3tybjYNvoevA/33qKNTuZIujLK l6qQ== X-Received: by 10.14.87.135 with SMTP id y7mr17404eee.57.1381289244807; Tue, 08 Oct 2013 20:27:24 -0700 (PDT) Original-Received: from [192.168.10.2] (93-113-74.netrun.cytanet.com.cy. [93.109.113.74]) by mx.google.com with ESMTPSA id b45sm83168592eef.4.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Oct 2013 20:27:23 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164032 Archived-At: On 08.10.2013 06:37, Stefan Monnier wrote: > When you're right after the newline that follows the "if" and you call > ruby-smie--backward-token do you then get ";" (and move to right after > the "if") or do you get "iuwu-mod" (and move to right before the "if")? The latter. > BTW, I don't guarantee that fixing ruby-smie--implicit-semi-p for this > case will give you the intended effect, but without it it'll be > difficult to get the intended effect: as it stands, SMIE considers the > newline after "if" to terminate the instruction, so the next instruction > is of course aligned with the previous one, and changing that in the > smie-rules part would invariably break other indentation cases. Thanks, I think I've fixed that with the change to ruby-smie-rules in 114587. By the way, could you explain what does the `when' predicate in (:before . "do") rule in ruby-smie-rules do? If I remove the `when' and just leave (smie-rule-parent), none of the indentation examples break, AFAICS.