From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r114452: * data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount. Date: Tue, 24 Sep 2013 17:26:51 -0700 Organization: UCLA Computer Science Department Message-ID: <52422DCB.5060103@cs.ucla.edu> References: <52420922.9030305@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1380068828 22695 80.91.229.3 (25 Sep 2013 00:27:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Sep 2013 00:27:08 +0000 (UTC) To: Daniel Colascione , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 25 02:27:11 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VOcwg-0007GQ-PU for ged-emacs-devel@m.gmane.org; Wed, 25 Sep 2013 02:27:10 +0200 Original-Received: from localhost ([::1]:48912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOcwg-0002S8-6U for ged-emacs-devel@m.gmane.org; Tue, 24 Sep 2013 20:27:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOcwX-0002Rh-8K for emacs-devel@gnu.org; Tue, 24 Sep 2013 20:27:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOcwP-0000wF-VF for emacs-devel@gnu.org; Tue, 24 Sep 2013 20:27:01 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:41956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOcwP-0000v3-LT for emacs-devel@gnu.org; Tue, 24 Sep 2013 20:26:53 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id A0DB139E8109; Tue, 24 Sep 2013 17:26:51 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mjBBf-Q1hwJF; Tue, 24 Sep 2013 17:26:51 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 4146139E80F8; Tue, 24 Sep 2013 17:26:51 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 In-Reply-To: <52420922.9030305@dancol.org> X-Enigmail-Version: 1.5.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163627 Archived-At: Daniel Colascione wrote: > POPCOUNT_STATIC_INLINE. What problem is it supposed to solve? It's supposed to solve the performance problem you mentioned, which it does. It's just a short-term fix until we get better and more-portable support for popcount in. (The new code currently doesn't work on OpenBSD, for example.) Once it's fixed, the other micro-optimization you mentioned may not even be applicable, not that it has any significant practical effect even now.