From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r114447: Some minor cleanups of recently-added bool vector code. Date: Tue, 24 Sep 2013 07:56:53 -0700 Organization: UCLA Computer Science Department Message-ID: <5241A835.9050104@cs.ucla.edu> References: <5241796B.1010902@dancol.org> <52417C11.7010808@yandex.ru> <834n9aia4v.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1380034650 25186 80.91.229.3 (24 Sep 2013 14:57:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Sep 2013 14:57:30 +0000 (UTC) Cc: dancol@dancol.org, emacs-devel@gnu.org To: Eli Zaretskii , Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 24 16:57:32 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VOU3Q-0001kX-4b for ged-emacs-devel@m.gmane.org; Tue, 24 Sep 2013 16:57:32 +0200 Original-Received: from localhost ([::1]:46497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOU3P-0007NO-O2 for ged-emacs-devel@m.gmane.org; Tue, 24 Sep 2013 10:57:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOU3G-0007MN-7h for emacs-devel@gnu.org; Tue, 24 Sep 2013 10:57:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOU38-0006Cy-Tq for emacs-devel@gnu.org; Tue, 24 Sep 2013 10:57:22 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:37185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOU30-0006B2-4r; Tue, 24 Sep 2013 10:57:06 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id C41F1A60003; Tue, 24 Sep 2013 07:56:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L6YdpaeV4ShY; Tue, 24 Sep 2013 07:56:57 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 4C3A0A60001; Tue, 24 Sep 2013 07:56:57 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 In-Reply-To: <834n9aia4v.fsf@gnu.org> X-Enigmail-Version: 1.5.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163608 Archived-At: Eli Zaretskii wrote: > Where are the real problems that would justify > rejecting old compilers? This cuts both ways, since some old compilers refuse to compile 'static inline', whereas the old compiler that Daniel wrote about presumably generates faster code if the function is marked 'static inline' than if it's marked 'static'. In trunk bzr 114452 I installed a workaround that should cause GCC to inline the function for the case that Daniel wrote about. I view this as a temporary hack; in the longer run I plan to fix this in a better way, by merging Daniel's performance improvements into the Gnulib module for popcount, and then having Emacs use that module. This will be more portable (and I think in some cases faster) than what we have now, and it should simplify the code in Emacs proper.