unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>, Dmitry Antipov <dmantipov@yandex.ru>
Cc: dancol@dancol.org, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r114447: Some minor cleanups of recently-added bool vector code.
Date: Tue, 24 Sep 2013 07:56:53 -0700	[thread overview]
Message-ID: <5241A835.9050104@cs.ucla.edu> (raw)
In-Reply-To: <834n9aia4v.fsf@gnu.org>

Eli Zaretskii wrote:
> Where are the real problems that would justify
> rejecting old compilers?

This cuts both ways, since some old compilers
refuse to compile 'static inline', whereas the
old compiler that Daniel wrote about presumably
generates faster code if the function is marked
'static inline' than if it's marked 'static'.

In trunk bzr 114452 I installed a workaround that
should cause GCC to inline the function for the case
that Daniel wrote about.  I view this as a temporary hack;
in the longer run I plan to fix this in a better
way, by merging Daniel's performance improvements
into the Gnulib module for popcount, and then
having Emacs use that module.  This will be more
portable (and I think in some cases faster) than what we
have now, and it should simplify the code in Emacs
proper.



  reply	other threads:[~2013-09-24 14:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1VOKEv-0006xW-Rw@vcs.savannah.gnu.org>
2013-09-24 11:37 ` [Emacs-diffs] trunk r114447: Some minor cleanups of recently-added bool vector code Daniel Colascione
2013-09-24 11:48   ` Dmitry Antipov
2013-09-24 14:09     ` Eli Zaretskii
2013-09-24 14:56       ` Paul Eggert [this message]
2013-09-24 16:18         ` Eli Zaretskii
2013-09-24 14:02   ` Jan Djärv
2013-09-24 23:12     ` Richard Stallman
2013-09-24 23:18       ` Daniel Colascione
2013-09-25 20:09         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5241A835.9050104@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=dancol@dancol.org \
    --cc=dmantipov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).