From: Daniel Colascione <dancol@dancol.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Set operations on bool-vectors
Date: Sat, 21 Sep 2013 01:49:48 -0700 [thread overview]
Message-ID: <523D5DAC.2000706@dancol.org> (raw)
In-Reply-To: <8761tubmho.fsf@igel.home>
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
On 9/21/13 1:35 AM, Andreas Schwab wrote:
> Daniel Colascione <dancol@dancol.org> writes:
>
>> On 9/21/13 12:36 AM, Andreas Schwab wrote:
>>> Also, the return type should be EMACS_INT,
>>> not ptrdiff_t.
>>
>> Well, vector_nbytes works with ptrdiff_t, and the allocation code works
>> in EMACS_INT. I'm not sure the distinction actually matters in this case.
>
> ptrdiff_t may be smaller than EMACS_INT.
We'll never overflow when we look at an already-allocated object --- but
we _can_ overflow in the initial allocation calculation. I'll fix it.
Thanks.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2013-09-21 8:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 22:59 Set operations on bool-vectors Daniel Colascione
2013-09-21 1:57 ` Stefan Monnier
2013-09-21 2:44 ` Daniel Colascione
2013-09-21 15:51 ` Stefan Monnier
2013-09-21 2:26 ` Dmitry Antipov
2013-09-21 2:49 ` Daniel Colascione
2013-09-21 7:16 ` Eli Zaretskii
2013-09-21 7:43 ` Daniel Colascione
2013-09-21 7:36 ` Andreas Schwab
2013-09-21 7:38 ` Daniel Colascione
2013-09-21 8:35 ` Andreas Schwab
2013-09-21 8:49 ` Daniel Colascione [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523D5DAC.2000706@dancol.org \
--to=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).