From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 8aef401b4f: LAP optimiser: more stack reduction hoisting Date: Tue, 14 Feb 2023 17:29:28 +0100 Message-ID: <523BE084-9B5F-4F2B-AC24-BB2859D191AE@acm.org> References: <167630393968.3716.18264966967495324218@vcs2.savannah.gnu.org> <20230213155859.EC4E9C13915@vcs2.savannah.gnu.org> <87pmadrxbh.fsf@tcd.ie> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16899"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 14 17:42:24 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRyNr-0004Br-Jy for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Feb 2023 17:42:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRyNI-0002JB-3H; Tue, 14 Feb 2023 11:41:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRyNG-0002J0-Bh for emacs-devel@gnu.org; Tue, 14 Feb 2023 11:41:46 -0500 Original-Received: from mail1464c50.megamailservers.eu ([91.136.14.64] helo=mail268c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRyNE-0007eE-1f for emacs-devel@gnu.org; Tue, 14 Feb 2023 11:41:46 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1676392172; bh=o1RMJBOkn5P2Y0a5py9gIZEUlCEouREIiY1QaJrUgaE=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=DRNDDYXneHVpoj7X86YxtfhuacV1HTJu/1aHWSUsuwYehKSaTLpcWnZyP0EkC2UsQ VsN+fG4aIkZ5h3F5FQ5Mu54AhcNXsVhY/c5BLLfWIkWXvyCMbe1Mwnovr8E8yFtBS2 7GUtCmgy69Y7xTq9pY9ipkdNS+xFUO3BVNUlhWVo= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se [188.150.171.209]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 31EGTTCr119005; Tue, 14 Feb 2023 16:29:31 +0000 In-Reply-To: <87pmadrxbh.fsf@tcd.ie> X-Mailer: Apple Mail (2.3654.120.0.1.14) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrudeifedgkedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffquffvqffrkfetpdfqfgfvpdfgpfggqdevhedtnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtggfuhfgjffevgffkfhfvofesthhqmhdthhdtvdenucfhrhhomhepofgrthhtihgrshcugfhnghguvghgnohrugcuoehmrghtthhirghsvgesrggtmhdrohhrgheqnecuggftrfgrthhtvghrnhepveekffdujefhkeehvdfgffeikefghfefvdekueffleegfeekueelhfejieefkefgnecukfhppedukeekrdduhedtrddujedurddvtdelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepudekkedrudehtddrudejuddrvddtledphhgvlhhopehsmhhtphgtlhhivghnthdrrghpphhlvgdpmhgrihhlfhhrohhmpehmrghtthhirghsvgesrggtmhdrohhrghdpnhgspghrtghpthhtohepvddprhgtphhtthhopegtohhnthhovhhosgesthgtugdrihgvpdhrtghpthhtohepvghmrggtshdquggvvhgvlhesghhnuhdrohhrgh X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.14.64; envelope-from=mattiase@acm.org; helo=mail268c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303281 Archived-At: 13 feb. 2023 kl. 23.54 skrev Basil L. Contovounesios : > I don't immediately spot anything wrong with the test Indeed, this was a somewhat roundabout LAP peephole bug, triggered by = the change you found by bisection but actually caused by a botched = refactoring a bit earlier, and ultimately by much older code. It should = be fixed now.